[XBEAN-190] XBeanNamespaceHandler does not close resource input streams

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 3.7
• Fix Version/s: 3.12
• Component/s: spring
• Assignee: Guillaume Nodet
• Reporter: Patrik Dudits
• Created: 10/Oct/11 09:12
• Updated: 02/Oct/12 19:11
• Resolved: 02/Oct/12 19:11

Description

I've got ActiveMQ RAR deployed onto Glassfish. Upon stopping of the connector, following warning is raised:

WARNING: Input stream has been finalized or forced closed without being explicitly closed; stream instantiation reported in following stack trace
java.lang.Throwable
	at com.sun.enterprise.loader.ASURLClassLoader$SentinelInputStream.<init>(ASURLClassLoader.java:1230)
	at com.sun.enterprise.loader.ASURLClassLoader$InternalJarURLConnection.getInputStream(ASURLClassLoader.java:1338)
	at java.net.URL.openStream(URL.java:1010)
	at java.lang.ClassLoader.getResourceAsStream(ClassLoader.java:1195)
	at com.sun.enterprise.loader.ASURLClassLoader.getResourceAsStream(ASURLClassLoader.java:872)
	at org.apache.xbean.spring.context.v2c.XBeanNamespaceHandler.loadResource(XBeanNamespaceHandler.java:835)
	at org.apache.xbean.spring.context.v2c.XBeanNamespaceHandler.findNamespaceProperties(XBeanNamespaceHandler.java:801)
	... (shortened) ...

The cause appears to be XBeanNamespaceHandler.findNamespaceProperties - the InputStream obtained on line 801 (in 3.7 sources), is used at line 812, but surrounding try lacks finally clause.