XalanJ2
  1. XalanJ2
  2. XALANJ-936

Xalan reports system-property('xsl:version') incorrectly

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 2.7
    • Labels:
      None
    • Environment:
      Operating System: All
      Platform: All
    • Xalan info:
      PatchAvailable

      Description

      We put out '1', whereas we should put out '1.0'.
      TestID: processorinfo01.xsl
      Note that the gold file incorrectly lists '1'; XSLTC correctly puts '1.0'.
      I'm basing this on my Monday morning reading of the spec, 12.4,
      'system-property(...)', second para, first bullet, "xsl:version ... this is the
      number 1.0".

        Activity

        Hide
        Joe Kesselman added a comment -

        I'm not sure.

        Section 2.2 says version is a number and "For this version of XSLT, the value
        should be 1.0. When the value is not equal to 1.0, forwards-compatible
        processing mode is enabled". Similar phrasing occurs when version is discussed
        elsewhere in the spec.

        I think there's room to argue that since they said to compare "the value" and
        declared that these are numbers, 1.0 and 1 are equal. They show an example of
        testing version's numeric value:
        <xsl:when test="system-property('xsl:version') >= 1.1">

        But even granting that this may not be technically necessary, I don't have any
        objection to changing how we display the version number to agree with XSLTC

        Show
        Joe Kesselman added a comment - I'm not sure. Section 2.2 says version is a number and "For this version of XSLT, the value should be 1.0. When the value is not equal to 1.0, forwards-compatible processing mode is enabled". Similar phrasing occurs when version is discussed elsewhere in the spec. I think there's room to argue that since they said to compare "the value" and declared that these are numbers, 1.0 and 1 are equal. They show an example of testing version's numeric value: <xsl:when test="system-property('xsl:version') >= 1.1"> But even granting that this may not be technically necessary, I don't have any objection to changing how we display the version number to agree with XSLTC
        Hide
        Sarah McNamara added a comment -

        This patch should resolve the issue for the Interpretive processor so that it reports
        the same version information as the XSLTC processor.

        Show
        Sarah McNamara added a comment - This patch should resolve the issue for the Interpretive processor so that it reports the same version information as the XSLTC processor.
        Hide
        Yash Talwar added a comment -

        I have reviewed the patch. I approve.
        Yash Talwar.

        Show
        Yash Talwar added a comment - I have reviewed the patch. I approve. Yash Talwar.
        Hide
        Sarah McNamara added a comment -

        Fixed in cvs.

        Show
        Sarah McNamara added a comment - Fixed in cvs.
        Hide
        Brian Minchau added a comment -

        Shane, as the issue reporter please confirm that this is fixed to your satisfaction in the Xalan-J 2.7 release, that was released on Aug 8, 2005, then we can close this issue.

        Show
        Brian Minchau added a comment - Shane, as the issue reporter please confirm that this is fixed to your satisfaction in the Xalan-J 2.7 release, that was released on Aug 8, 2005, then we can close this issue.
        Hide
        Brian Minchau added a comment -

        Closing the issue since it is over a year since 2.7.0 was released and Shane hasn't responded.

        Show
        Brian Minchau added a comment - Closing the issue since it is over a year since 2.7.0 was released and Shane hasn't responded.

          People

          • Assignee:
            Unassigned
            Reporter:
            Shane Curcuru
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development