[XALANJ-2556] Inconsistent Javadoc comment and code for execute(TransformerImpl) in org.apache.xalan.templates.ElemFallback

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 2.7.1, 2.7
• Security Level: No security risk; visible to anyone (Ordinary problems in Xalan projects. Anybody can view the issue.)
• Labels: javadoc
• Environment: Platform Independent
• Assignee: Unassigned
• Reporter: SHIN HWEI TAN
• Created: 08/Apr/12 08:30
• Updated: 13/Apr/12 01:25

Description

The Javadoc comment below states that the parameter transformer is a "non-null reference to the the current transform-time state.":
/**
...

• @param transformer non-null reference to the the current transform-time state.
  ...
  */
  public void execute(TransformerImpl transformer) throws TransformerException
  However, the method does not check the parameter for "null". It executes normally without throwing any exception when called with a null transformer.

Suggested Fixes:
1. Add parameter check for "null"
or
2. Remove "non-null" from @param.