Uploaded image for project: 'XalanJ2'
  1. XalanJ2
  2. XALANJ-2556

Inconsistent Javadoc comment and code for execute(TransformerImpl) in org.apache.xalan.templates.ElemFallback

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 2.7.1, 2.7
    • Fix Version/s: None
    • Component/s: None
    • Security Level: No security risk; visible to anyone (Ordinary problems in Xalan projects. Anybody can view the issue.)
    • Labels:
    • Environment:
      Platform Independent

      Description

      The Javadoc comment below states that the parameter transformer is a "non-null reference to the the current transform-time state.":
      /**
      ...

      • @param transformer non-null reference to the the current transform-time state.
        ...
        */
        public void execute(TransformerImpl transformer) throws TransformerException
        However, the method does not check the parameter for "null". It executes normally without throwing any exception when called with a null transformer.

      Suggested Fixes:
      1. Add parameter check for "null"
      or
      2. Remove "non-null" from @param.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              shinhwei SHIN HWEI TAN
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:

                Time Tracking

                Estimated:
                Original Estimate - 0.05h
                0.05h
                Remaining:
                Remaining Estimate - 0.05h
                0.05h
                Logged:
                Time Spent - Not Specified
                Not Specified