Uploaded image for project: 'XalanC'
  1. XalanC
  2. XALANC-800

Add CMake feature tests to replace specific platform definitions

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.12
    • Fix Version/s: 1.12
    • Component/s: XalanC
    • Labels:
      None

      Description

      Macros:

      __HPACC_THREAD_SAFE_RB_TREE
      __USE_STD_IOSTREAM
      WINDOWS_THREAD_FUNCTIONS
      XALAN_NEWLINE_IS_CRLF
      XALAN_NO_REENTRANT_TIME_FUNCTIONS
      XALAN_NON_ASCII_PLATFORM
      XALAN_PLATFORM_EXPORT
      XALAN_PLATFORM_IMPORT
      XALAN_POSIX2_AVAILABLE
      XALAN_STATIC_ASSERT
      XALAN_WINDOWS
      XALAN_WINDOWS_DIR_FUNCTIONS
      

      The underlying problem is that these hardcoded assumptions can be broken. Case in point, XALAN_NO_REENTRANT_TIME_FUNCTIONS is defined for GCC under MinGW... but current MinGW actually provides localtime_t and gmtime_r, which breaks building due to mutually incompatible function declarations. Feature tests will remove these assumptions and make building Xalan more robust and able to adapt to changes in platforms over time.

        Attachments

          Activity

            People

            • Assignee:
              rleigh Roger Leigh
              Reporter:
              rleigh Roger Leigh
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: