[WW-5423] Query Parameters in Multipart Requests not working in v7 M6

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 7.0.0
• Fix Version/s: 7.0.0
• Assignee: Unassigned
• Reporter: Philip Crider
• Created: 22/May/24 16:49
• Updated: 10/Jun/24 05:02
• Resolved: 10/Jun/24 05:02

Description

One of the changes in https://github.com/apache/struts/pull/861 broke query parameters in multipart requests. Their values are being lost.

This is the old implementation, which returns null if the parameter doesn't exist.

public String[] getParameterValues(String name) {
    List<String> v = params.get(name);
    if (v != null && !v.isEmpty()) {
        return v.toArray(new String[0]);
    }

    return null;
} 

 

And this is the new implementation, which returns an empty array in that case.

public String[] getParameterValues(String name) {        
    return parameters.getOrDefault(name, Collections.emptyList())
            .toArray(String[]::new);
}

 

This method in MultiPartRequestWrapper is expecting null to be returned in that case.

public String[] getParameterValues(String name) {
    return ((multi == null) || (multi.getParameterValues(name) == null)) ? super.getParameterValues(name) : multi.getParameterValues(name);
}

 

 

Issue Links

• links to: GitHub Pull Request #954