[WW-5096] Struts2 StaticParametersInterceptor's addParametersToContext method is not working as expected.

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.5.26, 6.0.0
• Assignee: Unassigned
• Reporter: Akash Shah
• Created: 13/Nov/20 11:45
• Updated: 02/Nov/21 06:06
• Resolved: 20/Nov/20 06:49

Description

In our current project we are upgrading struts 2.3.35 to 2.5.22 and we encounter some minor bug in below code of addParametersToContext method of StaticParametersInterceptor.

in method, code is like below.

 

if (overwrite) {
            if (previousParams != null) {
                combinedParams = combinedParams.withParent(previousParams);
            }
            if (newParams != null) {
                combinedParams = combinedParams.withExtraParams(newParams);
            }
        } else {
            if (newParams != null) {
                combinedParams = combinedParams.withExtraParams(newParams);
            }
            if (previousParams != null) {
                combinedParams = combinedParams.withParent(previousParams);
            }
        }

 

But here overwrite functionality will not work since only if condition order was changed in else condition of overwrite.

instead of this, as per me, code would be like below

if (overwrite) {
            if (previousParams != null) {
                combinedParams = combinedParams.withParent(previousParams);
            }
            if (newParams != null) {
                combinedParams = combinedParams.withExtraParams(newParams);
            }
        } else {
            if (newParams != null) {  
             HttpParameters newHttpParameters = HttpParameters.create(newParams).build();
                combinedParams = combinedParams.withParent(newParams);
            }
            if (previousParams != null) {
                combinedParams = combinedParams.withExtraParams(previousParams);
            }
        }

 

And that's how ac.setParameters(combinedParams.build()); will work because in build method, requestParameterMap will override parent parameters.

 

Issue Links

• links to: GitHub Pull Request #446
• links to: GitHub Pull Request #449