[WW-4971] s:include tag fails with truncated content in certain circumstances

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.3.36, 2.5.18
• Fix Version/s: 2.5.20, 6.0.0
• Component/s: Core Tags

Environment

Windows 10, Java 7/8 (but issue isn't environment specific)

• Assignee: Unassigned
• Reporter: James Chaplin
• Created: 19/Oct/18 05:25
• Updated: 02/Nov/21 06:08
• Resolved: 01/Nov/18 20:15

Description

Hello Apache Struts Team.

There is an issue with the Struts include tag (s:include) when processing includes on a page that isn't using UTF-8 encoding (e.g. ISO-8859-1 or Windows-1252 page encoding).

In some circumstances the s:include tag results in truncated content from the child page (i.e. the parent page including the child page via s:include experiences incomplete rendering of the included content).  This happens when the included page contains certain characters (e.g. 'ç') in a non-UTF8 encoding (whether directly or from a resource bundle).

There are no warnings produced in the logs (even in debug mode), so the issue can only be detected visually when things fail.

Changing all the content to UTF-8 is a workaround, but that is not feasible in all circumstances.  Given the preceding and the lack of warnings I'm initially submitting it as a major priority.

I will attempt to submit a bugfix for consideration shortly.

Issue Links

• links to: GitHub Pull Request #257