[WW-4958] File upload fails from certain clients

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.5.17
• Fix Version/s: 2.5.22, 6.0.0
• Component/s: Dispatch Filter
• Assignee: Lukasz Lenart
• Reporter: Tamás Faragó
• Created: 07/Sep/18 03:20
• Updated: 02/Apr/22 14:33
• Resolved: 23/Apr/19 09:51

Description

2.5.11 added more validation on whether to accept file uploads. Previously there was only a check if the HTTP header contained "multipart/form-data", now there is the following regex in Dispatcher::isMultipartRequest.

 

public static final String MULTIPART_FORM_DATA_REGEX = "^multipart/form-data(; boundary=[0-9a-zA-Z'()+_,\\-./:=?]{1,70})?(;charset=[a-zA-Z\\-0-9]{3,14})?";

 

This is too restrictive, apache http client for example adds a white space between the semicolon and "charset" and thus all file uploads are failing unless this regex is overwritten in the config. 

Issue Links

• relates to: WW-5176 multipart/form-data parameters are not processed when charset is placed before boundary in Content-Type header
• links to: GitHub Pull Request #344
• links to: GitHub Pull Request #350