[WW-4928] Setting struts.devMode from system property not working as described

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.5.14.1
• Fix Version/s: 6.0.0
• Component/s: Core
• Labels: documentation easyfix

Environment

**Windows, Linux, Solaris

• Assignee: Aleksandr Mashchenko
• Reporter: Peter J Ford
• Created: 22/Mar/18 17:31
• Updated: 14/Jun/22 09:47
• Resolved: 23/Mar/18 06:44

Description

According to http://struts.apache.org/core-developers/constant-configuration.html the struts.devMode setting can be read from environment strings or system properties. This works correctly when setting from an environment string - for example:

<constant name="struts.devMode" value="${env.STRUTS_DEV_MODE:false}"/>

However it does not work for system properties, such as setting "-DstrutsDevMode=true" as a system property and this in struts.xml:

<constant name="struts.devMode" value="${strutsDevMode:false}"/>

Having dug through the source I found that this is to do with the way the value substitutor is configured, and that using ":-" instead of ":" as the separator string when using system properties will work:

<constant name="struts.devMode" value="${strutsDevMode:-false}"/>

 

Issue Links

• links to: GitHub Pull Request #217