Uploaded image for project: 'Struts 2'
  1. Struts 2
  2. WW-4801

Duplicate hidden input field checkboxListHandler

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5.10
    • Fix Version/s: 2.5.12
    • Labels:
      None

      Description

      The Java Templates checkboxListHandler creates multiple hidden elements, one for each item on the list. Compared to the default handler which only creates one.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user gregh3269 opened a pull request:

          https://github.com/apache/struts/pull/140

          WW-4801 Only one hidden field per checkboxlist.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/gregh3269/struts master

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/struts/pull/140.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #140


          commit 46153e78da63c7da40d0dbd410de1e5f25b462ab
          Author: gregh <gregh3269@gmail.com>
          Date: 2017-05-30T14:02:23Z

          WW-4801 Only one hidden field per checkboxlist.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user gregh3269 opened a pull request: https://github.com/apache/struts/pull/140 WW-4801 Only one hidden field per checkboxlist. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gregh3269/struts master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/struts/pull/140.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #140 commit 46153e78da63c7da40d0dbd410de1e5f25b462ab Author: gregh <gregh3269@gmail.com> Date: 2017-05-30T14:02:23Z WW-4801 Only one hidden field per checkboxlist.
          Hide
          lukaszlenart Lukasz Lenart added a comment -

          You meant when compared to checkboxlist.ftl from the simple theme, right?

          Show
          lukaszlenart Lukasz Lenart added a comment - You meant when compared to checkboxlist.ftl from the simple theme, right?
          Hide
          ghuber Greg Huber added a comment -

          Yes, from the code the hidden field is created after </@s.iterator> rather than inside the while loop for the java templates.

          Show
          ghuber Greg Huber added a comment - Yes, from the code the hidden field is created after </@s.iterator> rather than inside the while loop for the java templates.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 46153e78da63c7da40d0dbd410de1e5f25b462ab in struts's branch refs/heads/master from Greg Huber
          [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=46153e7 ]

          WW-4801 Only one hidden field per checkboxlist.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 46153e78da63c7da40d0dbd410de1e5f25b462ab in struts's branch refs/heads/master from Greg Huber [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=46153e7 ] WW-4801 Only one hidden field per checkboxlist.
          Hide
          lukaszlenart Lukasz Lenart added a comment -

          PR got merged, thanks!

          Show
          lukaszlenart Lukasz Lenart added a comment - PR got merged, thanks!
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 0100a6bebf90062ee4356dd170caa3047892b601 in struts's branch refs/heads/master from Lukasz Lenart
          [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=0100a6b ]

          WW-4801 fixes duplicated hidden field in checkboxListHandler

          Show
          jira-bot ASF subversion and git services added a comment - Commit 0100a6bebf90062ee4356dd170caa3047892b601 in struts's branch refs/heads/master from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=0100a6b ] WW-4801 fixes duplicated hidden field in checkboxListHandler
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/struts/pull/140

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/struts/pull/140
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Jenkins build Struts-JDK7-master #634 (See https://builds.apache.org/job/Struts-JDK7-master/634/)
          WW-4801 Only one hidden field per checkboxlist. (gregh3269: rev 46153e78da63c7da40d0dbd410de1e5f25b462ab)

          • (edit) plugins/javatemplates/src/main/java/org/apache/struts2/views/java/simple/CheckboxListHandler.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Jenkins build Struts-JDK7-master #634 (See https://builds.apache.org/job/Struts-JDK7-master/634/ ) WW-4801 Only one hidden field per checkboxlist. (gregh3269: rev 46153e78da63c7da40d0dbd410de1e5f25b462ab) (edit) plugins/javatemplates/src/main/java/org/apache/struts2/views/java/simple/CheckboxListHandler.java

            People

            • Assignee:
              ghuber Greg Huber
              Reporter:
              ghuber Greg Huber
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development