Uploaded image for project: 'Struts 2'
  1. Struts 2
  2. WW-4770

Revision number still missing from dojo.js and dojo.js.uncompressed.js

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.31
    • Fix Version/s: 2.3.33
    • Component/s: Plugin - Dojo Tags
    • Labels:
      None

      Description

      WW-4349 discusses an issue where the revision number is missing from the Dojo JavaScript files which causes an error in the browser console when processing a regular expression. This error was only fixed for some of the files which was actually noted in this JIRA but seemingly never implemented. I have also written this as a comment in this JIRA.

        Issue Links

          Activity

          Hide
          lukaszlenart Lukasz Lenart added a comment -

          PR got merged so this got resolved

          Show
          lukaszlenart Lukasz Lenart added a comment - PR got merged so this got resolved
          Hide
          hudson Hudson added a comment -

          UNSTABLE: Integrated in Jenkins build Struts-JDK6-support-2.3 #1061 (See https://builds.apache.org/job/Struts-JDK6-support-2.3/1061/)
          WW-4770 Fixes problem with dojo.version (stefaan.dutry: rev 9e8627ca669ec566bbedd638fc6010e8ae364160)

          • (edit) plugins/dojo/src/main/resources/org/apache/struts2/static/dojo/dojo.js
          • (edit) plugins/dojo/src/main/resources/org/apache/struts2/static/dojo/dojo.js.uncompressed.js
          • (edit) plugins/dojo/src/main/resources/org/apache/struts2/static/dojo/struts_dojo.js.uncompressed.js
          Show
          hudson Hudson added a comment - UNSTABLE: Integrated in Jenkins build Struts-JDK6-support-2.3 #1061 (See https://builds.apache.org/job/Struts-JDK6-support-2.3/1061/ ) WW-4770 Fixes problem with dojo.version (stefaan.dutry: rev 9e8627ca669ec566bbedd638fc6010e8ae364160) (edit) plugins/dojo/src/main/resources/org/apache/struts2/static/dojo/dojo.js (edit) plugins/dojo/src/main/resources/org/apache/struts2/static/dojo/dojo.js.uncompressed.js (edit) plugins/dojo/src/main/resources/org/apache/struts2/static/dojo/struts_dojo.js.uncompressed.js
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/struts/pull/126

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/struts/pull/126
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 9e8627ca669ec566bbedd638fc6010e8ae364160 in struts's branch refs/heads/support-2-3 from Stefaan Dutry
          [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=9e8627c ]

          WW-4770 Fixes problem with dojo.version

          Show
          jira-bot ASF subversion and git services added a comment - Commit 9e8627ca669ec566bbedd638fc6010e8ae364160 in struts's branch refs/heads/support-2-3 from Stefaan Dutry [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=9e8627c ] WW-4770 Fixes problem with dojo.version
          Hide
          sdutry Stefaan Dutry added a comment -
          Show
          sdutry Stefaan Dutry added a comment - pull request made
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user sdutry opened a pull request:

          https://github.com/apache/struts/pull/126

          WW-4770 Fixes problem with dojo.version

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/sdutry/struts issue/WW-4770

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/struts/pull/126.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #126


          commit 9e8627ca669ec566bbedd638fc6010e8ae364160
          Author: Stefaan Dutry <stefaan.dutry@gmail.com>
          Date: 2017-03-24T20:34:31Z

          WW-4770 Fixes problem with dojo.version


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user sdutry opened a pull request: https://github.com/apache/struts/pull/126 WW-4770 Fixes problem with dojo.version You can merge this pull request into a Git repository by running: $ git pull https://github.com/sdutry/struts issue/ WW-4770 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/struts/pull/126.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #126 commit 9e8627ca669ec566bbedd638fc6010e8ae364160 Author: Stefaan Dutry <stefaan.dutry@gmail.com> Date: 2017-03-24T20:34:31Z WW-4770 Fixes problem with dojo.version
          Hide
          lukaszlenart Lukasz Lenart added a comment -

          You can open a PR on the Github against the support-2-3 branch

          Show
          lukaszlenart Lukasz Lenart added a comment - You can open a PR on the Github against the support-2-3 branch

            People

            • Assignee:
              Unassigned
              Reporter:
              mtx Martin Thiim
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development