Uploaded image for project: 'Struts 2'
  1. Struts 2
  2. WW-4762

DefaultLocalizedTextProvider refactoring

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.5.12
    • Component/s: Core
    • Labels:
      None

      Description

      Now that DefaultLocalizedTextProvider is a bean, would it be possible to refactor the code to allow an override so we can change the default behavior on the package searching for the resource.properties files. Currently is does an extensive search up the class interfaces first which on busy screens slows things down and is an unnecessary overhead.

      ie As I have migrated from struts1 my main UI resources are in the default ApplicationResources.properties file and are shared across struts ui classes in various packages. I would not want to duplicate the .properties entries for maintenance etc.
      I would then want to search the default ApplicationResources.properties first and then package class (for validation messages) and then possibly up the interfaces (which would not make sense for me as I do not use this logic).

      Discussion related to this
      http://markmail.org/message/v2oc6c35swfwzwid

        Issue Links

          Activity

          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 45d1a491311a82f6b2404d839e7e18269a26192f in struts's branch refs/heads/default-provider from Lukasz Lenart
          [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=45d1a49 ]

          WW-4762 Drops unused code

          Show
          jira-bot ASF subversion and git services added a comment - Commit 45d1a491311a82f6b2404d839e7e18269a26192f in struts's branch refs/heads/default-provider from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=45d1a49 ] WW-4762 Drops unused code
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 3ffc9b8450845d7a90a623607e3b4bb05888e2f9 in struts's branch refs/heads/default-provider from Lukasz Lenart
          [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=3ffc9b8 ]

          WW-4762 Drops unused imports

          Show
          jira-bot ASF subversion and git services added a comment - Commit 3ffc9b8450845d7a90a623607e3b4bb05888e2f9 in struts's branch refs/heads/default-provider from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=3ffc9b8 ] WW-4762 Drops unused imports
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 8bf77a1d19d31dbc8574dcbf958c3da2a4724c84 in struts's branch refs/heads/default-provider from Lukasz Lenart
          [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=8bf77a1 ]

          WW-4762 Uses Struts prefix for the main implementation

          Show
          jira-bot ASF subversion and git services added a comment - Commit 8bf77a1d19d31dbc8574dcbf958c3da2a4724c84 in struts's branch refs/heads/default-provider from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=8bf77a1 ] WW-4762 Uses Struts prefix for the main implementation
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 2e23d7a07ea4313136dc38b8de2451b04c882064 in struts's branch refs/heads/default-provider from Lukasz Lenart
          [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=2e23d7a ]

          WW-4762 Extracts base abstract class

          Show
          jira-bot ASF subversion and git services added a comment - Commit 2e23d7a07ea4313136dc38b8de2451b04c882064 in struts's branch refs/heads/default-provider from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=2e23d7a ] WW-4762 Extracts base abstract class
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit bb19a6209886795b76385e48fd86424c144ee029 in struts's branch refs/heads/default-provider from Lukasz Lenart
          [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=bb19a62 ]

          WW-4762 Introduces default provider which only uses default bundles

          Show
          jira-bot ASF subversion and git services added a comment - Commit bb19a6209886795b76385e48fd86424c144ee029 in struts's branch refs/heads/default-provider from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=bb19a62 ] WW-4762 Introduces default provider which only uses default bundles
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user lukaszlenart opened a pull request:

          https://github.com/apache/struts/pull/137

          WW-4762: Default provider

          Implements a default text provider which only operates on defined default bundles and those provided via `struts.custom.i18n.resources`

          Implements WW-4762(https://issues.apache.org/jira/browse/WW-4762)

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/lukaszlenart/struts default-provider

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/struts/pull/137.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #137


          commit 45d1a491311a82f6b2404d839e7e18269a26192f
          Author: Lukasz Lenart <lukaszlenart@apache.org>
          Date: 2017-04-26T09:55:49Z

          WW-4762 Drops unused code

          commit 3ffc9b8450845d7a90a623607e3b4bb05888e2f9
          Author: Lukasz Lenart <lukaszlenart@apache.org>
          Date: 2017-04-26T09:56:09Z

          WW-4762 Drops unused imports

          commit 8bf77a1d19d31dbc8574dcbf958c3da2a4724c84
          Author: Lukasz Lenart <lukaszlenart@apache.org>
          Date: 2017-04-26T09:56:48Z

          WW-4762 Uses Struts prefix for the main implementation

          commit 2e23d7a07ea4313136dc38b8de2451b04c882064
          Author: Lukasz Lenart <lukaszlenart@apache.org>
          Date: 2017-04-26T10:24:57Z

          WW-4762 Extracts base abstract class

          commit bb19a6209886795b76385e48fd86424c144ee029
          Author: Lukasz Lenart <lukaszlenart@apache.org>
          Date: 2017-04-26T18:28:11Z

          WW-4762 Introduces default provider which only uses default bundles


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user lukaszlenart opened a pull request: https://github.com/apache/struts/pull/137 WW-4762 : Default provider Implements a default text provider which only operates on defined default bundles and those provided via `struts.custom.i18n.resources` Implements WW-4762 ( https://issues.apache.org/jira/browse/WW-4762 ) You can merge this pull request into a Git repository by running: $ git pull https://github.com/lukaszlenart/struts default-provider Alternatively you can review and apply these changes as the patch at: https://github.com/apache/struts/pull/137.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #137 commit 45d1a491311a82f6b2404d839e7e18269a26192f Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-04-26T09:55:49Z WW-4762 Drops unused code commit 3ffc9b8450845d7a90a623607e3b4bb05888e2f9 Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-04-26T09:56:09Z WW-4762 Drops unused imports commit 8bf77a1d19d31dbc8574dcbf958c3da2a4724c84 Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-04-26T09:56:48Z WW-4762 Uses Struts prefix for the main implementation commit 2e23d7a07ea4313136dc38b8de2451b04c882064 Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-04-26T10:24:57Z WW-4762 Extracts base abstract class commit bb19a6209886795b76385e48fd86424c144ee029 Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-04-26T18:28:11Z WW-4762 Introduces default provider which only uses default bundles
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user lukaszlenart commented on the issue:

          https://github.com/apache/struts/pull/137

          This is ready to test, to test the new bean you must specify the following constant in `struts.xml`

          ```xml
          <constant name="struts.localizedTextProvider" value="default-only" />
          ```

          now you can play with `struts.custom.i18n.resources` to define additional resource bundles.

          Show
          githubbot ASF GitHub Bot added a comment - Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/137 This is ready to test, to test the new bean you must specify the following constant in `struts.xml` ```xml <constant name="struts.localizedTextProvider" value="default-only" /> ``` now you can play with `struts.custom.i18n.resources` to define additional resource bundles.
          Hide
          greg.huber@ricoh.co.uk Greg Huber added a comment -

          Where would the git repo be for this?

          Its not here

          https://github.com/apache/struts

          Show
          greg.huber@ricoh.co.uk Greg Huber added a comment - Where would the git repo be for this? Its not here https://github.com/apache/struts
          Show
          lukaszlenart Lukasz Lenart added a comment - It's here https://github.com/lukaszlenart/struts/tree/default-provider
          Hide
          ghuber Greg Huber added a comment -

          If I just copy in the core jar and try and run the app, I get

          java.lang.NullPointerException
          at org.apache.struts2.tiles.StrutsTilesLocaleResolver.resolveLocale(StrutsTilesLocaleResolver.java:51)
          at org.apache.tiles.definition.UnresolvingLocaleDefinitionsFactory.getDefinition(UnresolvingLocaleDefinitionsFactory.java:86)
          at org.apache.tiles.impl.BasicTilesContainer.getDefinition(BasicTilesContainer.java:286)
          at org.apache.tiles.impl.BasicTilesContainer.isValidDefinition(BasicTilesContainer.java:273)
          at org.apache.tiles.TilesContainerWrapper.isValidDefinition(TilesContainerWrapper.java:88)
          at org.apache.tiles.impl.mgmt.CachingTilesContainer.isValidDefinition(CachingTilesContainer.java:100)
          at org.apache.struts2.views.tiles.TilesResult.doExecute(TilesResult.java:139)
          at org.apache.struts2.result.StrutsResultSupport.execute(StrutsResultSupport.java:208)
          ..

          Show
          ghuber Greg Huber added a comment - If I just copy in the core jar and try and run the app, I get java.lang.NullPointerException at org.apache.struts2.tiles.StrutsTilesLocaleResolver.resolveLocale(StrutsTilesLocaleResolver.java:51) at org.apache.tiles.definition.UnresolvingLocaleDefinitionsFactory.getDefinition(UnresolvingLocaleDefinitionsFactory.java:86) at org.apache.tiles.impl.BasicTilesContainer.getDefinition(BasicTilesContainer.java:286) at org.apache.tiles.impl.BasicTilesContainer.isValidDefinition(BasicTilesContainer.java:273) at org.apache.tiles.TilesContainerWrapper.isValidDefinition(TilesContainerWrapper.java:88) at org.apache.tiles.impl.mgmt.CachingTilesContainer.isValidDefinition(CachingTilesContainer.java:100) at org.apache.struts2.views.tiles.TilesResult.doExecute(TilesResult.java:139) at org.apache.struts2.result.StrutsResultSupport.execute(StrutsResultSupport.java:208) ..
          Hide
          ghuber Greg Huber added a comment - - edited

          ok, I copied the tiles plugin also (and now the tiles error is gone and it works).

          When i add

          <constant name="struts.localizedTextProvider" value="default-only" />
          

          I get this (core jar)

          SEVERE: Servlet.service() for servlet [default] in context with path [] threw exception
          java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: Unable to load bean com.opensymphony.xwork2.LocalizedTextProvider (default-only) - [unknown location]
          at com.opensymphony.xwork2.inject.ContainerBuilder$4.create(ContainerBuilder.java:131)
          	at com.opensymphony.xwork2.inject.Scope$2$1.create(Scope.java:52)
          	at com.opensymphony.xwork2.inject.ContainerImpl.getInstance(ContainerImpl.java:491)
          	at com.opensymphony.xwork2.inject.ContainerImpl.getInstance(ContainerImpl.java:501)
          	at com.opensymphony.xwork2.inject.ContainerImpl$9.call(ContainerImpl.java:532)
          	at com.opensymphony.xwork2.inject.ContainerImpl.callInContext(ContainerImpl.java:560)
          	at com.opensymphony.xwork2.inject.ContainerImpl.getInstance(ContainerImpl.java:530)
          	at org.apache.struts2.dispatcher.PrepareOperations.createActionContext(PrepareOperations.java:84)
          	at org.apache.struts2.dispatcher.filter.StrutsPrepareAndExecuteFilter.doFilter(StrutsPrepareAndExecuteFilter.java:134)
          

          To make it work :

          <constant name="struts.localizedTextProvider" value="default-only" />
          

          and then update my :

          struts.custom.i18n.resources=ApplicationResources
          

          to include EventAdd, EventEdit, FolderAdd, FolderEdit, etc there are probably about 40 files as they are validator message.properties etc

          ie.

          struts.custom.i18n.resources=ApplicationResources, EventAdd, EventEdit, FolderAdd, FolderEdit
          
          Show
          ghuber Greg Huber added a comment - - edited ok, I copied the tiles plugin also (and now the tiles error is gone and it works). When i add <constant name= "struts.localizedTextProvider" value= "default-only" /> I get this (core jar) SEVERE: Servlet.service() for servlet [default] in context with path [] threw exception java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: Unable to load bean com.opensymphony.xwork2.LocalizedTextProvider (default-only) - [unknown location] at com.opensymphony.xwork2.inject.ContainerBuilder$4.create(ContainerBuilder.java:131) at com.opensymphony.xwork2.inject.Scope$2$1.create(Scope.java:52) at com.opensymphony.xwork2.inject.ContainerImpl.getInstance(ContainerImpl.java:491) at com.opensymphony.xwork2.inject.ContainerImpl.getInstance(ContainerImpl.java:501) at com.opensymphony.xwork2.inject.ContainerImpl$9.call(ContainerImpl.java:532) at com.opensymphony.xwork2.inject.ContainerImpl.callInContext(ContainerImpl.java:560) at com.opensymphony.xwork2.inject.ContainerImpl.getInstance(ContainerImpl.java:530) at org.apache.struts2.dispatcher.PrepareOperations.createActionContext(PrepareOperations.java:84) at org.apache.struts2.dispatcher.filter.StrutsPrepareAndExecuteFilter.doFilter(StrutsPrepareAndExecuteFilter.java:134) To make it work : <constant name= "struts.localizedTextProvider" value= "default-only" /> and then update my : struts.custom.i18n.resources=ApplicationResources to include EventAdd, EventEdit, FolderAdd, FolderEdit, etc there are probably about 40 files as they are validator message.properties etc ie. struts.custom.i18n.resources=ApplicationResources, EventAdd, EventEdit, FolderAdd, FolderEdit
          Hide
          lukaszlenart Lukasz Lenart added a comment - - edited

          I don't really understand, you said that using

          <constant name="struts.localizedTextProvider" value="default-only" />
          

          throws an exception but then you have used exactly the same constant and it worked out. Does it mean that this works for you?

          Also you said you have over 40 properties files ... so the DefaultLocalizedTextProvider isn't for you and you should stick with the one that performs package scans to discover bundles.

          Show
          lukaszlenart Lukasz Lenart added a comment - - edited I don't really understand, you said that using <constant name= "struts.localizedTextProvider" value= "default-only" /> throws an exception but then you have used exactly the same constant and it worked out. Does it mean that this works for you? Also you said you have over 40 properties files ... so the DefaultLocalizedTextProvider isn't for you and you should stick with the one that performs package scans to discover bundles.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user lukaszlenart commented on the issue:

          https://github.com/apache/struts/pull/137

          Any objections to merge this PR?

          Show
          githubbot ASF GitHub Bot added a comment - Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/137 Any objections to merge this PR?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user gregh3269 commented on the issue:

          https://github.com/apache/struts/pull/137

          I can re-test it when merged.

          Show
          githubbot ASF GitHub Bot added a comment - Github user gregh3269 commented on the issue: https://github.com/apache/struts/pull/137 I can re-test it when merged.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 45d1a491311a82f6b2404d839e7e18269a26192f in struts's branch refs/heads/master from Lukasz Lenart
          [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=45d1a49 ]

          WW-4762 Drops unused code

          Show
          jira-bot ASF subversion and git services added a comment - Commit 45d1a491311a82f6b2404d839e7e18269a26192f in struts's branch refs/heads/master from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=45d1a49 ] WW-4762 Drops unused code
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 3ffc9b8450845d7a90a623607e3b4bb05888e2f9 in struts's branch refs/heads/master from Lukasz Lenart
          [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=3ffc9b8 ]

          WW-4762 Drops unused imports

          Show
          jira-bot ASF subversion and git services added a comment - Commit 3ffc9b8450845d7a90a623607e3b4bb05888e2f9 in struts's branch refs/heads/master from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=3ffc9b8 ] WW-4762 Drops unused imports
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 8bf77a1d19d31dbc8574dcbf958c3da2a4724c84 in struts's branch refs/heads/master from Lukasz Lenart
          [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=8bf77a1 ]

          WW-4762 Uses Struts prefix for the main implementation

          Show
          jira-bot ASF subversion and git services added a comment - Commit 8bf77a1d19d31dbc8574dcbf958c3da2a4724c84 in struts's branch refs/heads/master from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=8bf77a1 ] WW-4762 Uses Struts prefix for the main implementation
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 2e23d7a07ea4313136dc38b8de2451b04c882064 in struts's branch refs/heads/master from Lukasz Lenart
          [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=2e23d7a ]

          WW-4762 Extracts base abstract class

          Show
          jira-bot ASF subversion and git services added a comment - Commit 2e23d7a07ea4313136dc38b8de2451b04c882064 in struts's branch refs/heads/master from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=2e23d7a ] WW-4762 Extracts base abstract class
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/struts/pull/137

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/struts/pull/137
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit bb19a6209886795b76385e48fd86424c144ee029 in struts's branch refs/heads/master from Lukasz Lenart
          [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=bb19a62 ]

          WW-4762 Introduces default provider which only uses default bundles

          Show
          jira-bot ASF subversion and git services added a comment - Commit bb19a6209886795b76385e48fd86424c144ee029 in struts's branch refs/heads/master from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=bb19a62 ] WW-4762 Introduces default provider which only uses default bundles
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 7360b5e1956f415866c189d7adda861456d4d069 in struts's branch refs/heads/master from Lukasz Lenart
          [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=7360b5e ]

          WW-4762 Moves common method up

          Show
          jira-bot ASF subversion and git services added a comment - Commit 7360b5e1956f415866c189d7adda861456d4d069 in struts's branch refs/heads/master from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=7360b5e ] WW-4762 Moves common method up
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit fd168c423f70383a6240cba9809a87b661ef39de in struts's branch refs/heads/master from Lukasz Lenart
          [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=fd168c4 ]

          WW-4762 Extracts common method

          Show
          jira-bot ASF subversion and git services added a comment - Commit fd168c423f70383a6240cba9809a87b661ef39de in struts's branch refs/heads/master from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=fd168c4 ] WW-4762 Extracts common method
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 4604333649a0060421c07cd5520c8285ca0c135f in struts's branch refs/heads/master from Lukasz Lenart
          [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=4604333 ]

          WW-4762 Defines default-only bean

          Show
          jira-bot ASF subversion and git services added a comment - Commit 4604333649a0060421c07cd5520c8285ca0c135f in struts's branch refs/heads/master from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=4604333 ] WW-4762 Defines default-only bean
          Hide
          lukaszlenart Lukasz Lenart added a comment -

          PR got merged

          Show
          lukaszlenart Lukasz Lenart added a comment - PR got merged
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit cb0f42abccc884b2243fd9b9aac6a63f109e1af4 in struts's branch refs/heads/master from Lukasz Lenart
          [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=cb0f42a ]

          WW-4762 Adds additiona LocalizedTextProvider which uses only default bundles

          Show
          jira-bot ASF subversion and git services added a comment - Commit cb0f42abccc884b2243fd9b9aac6a63f109e1af4 in struts's branch refs/heads/master from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=cb0f42a ] WW-4762 Adds additiona LocalizedTextProvider which uses only default bundles
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 3a9f86a605354c80ded30b3f47524dff1456d3a1 in struts's branch refs/heads/master from Lukasz Lenart
          [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=3a9f86a ]

          WW-4762 Uses global to better express the meaning

          Show
          jira-bot ASF subversion and git services added a comment - Commit 3a9f86a605354c80ded30b3f47524dff1456d3a1 in struts's branch refs/heads/master from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=3a9f86a ] WW-4762 Uses global to better express the meaning
          Show
          lukaszlenart Lukasz Lenart added a comment - Docs updated as well https://cwiki.apache.org/confluence/display/WW/Localization#Localization-Usingonlyglobalbundles
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user lukaszlenart commented on the issue:

          https://github.com/apache/struts/pull/137

          Please see docs, I have renamed the constant and the class
          https://cwiki.apache.org/confluence/display/WW/Localization#Localization-Usingonlyglobalbundles

          Show
          githubbot ASF GitHub Bot added a comment - Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/137 Please see docs, I have renamed the constant and the class https://cwiki.apache.org/confluence/display/WW/Localization#Localization-Usingonlyglobalbundles
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Struts-JDK7-master #631 (See https://builds.apache.org/job/Struts-JDK7-master/631/)
          WW-4762 Drops unused code (lukaszlenart: rev 45d1a491311a82f6b2404d839e7e18269a26192f)

          • (edit) core/src/main/java/org/apache/struts2/util/StrutsTestCaseHelper.java
            WW-4762 Drops unused imports (lukaszlenart: rev 3ffc9b8450845d7a90a623607e3b4bb05888e2f9)
          • (edit) core/src/test/java/org/apache/struts2/config/PropertiesConfigurationProviderTest.java
          • (edit) core/src/main/java/org/apache/struts2/dispatcher/Dispatcher.java
          • (edit) core/src/main/java/com/opensymphony/xwork2/DefaultTextProvider.java
            WW-4762 Uses Struts prefix for the main implementation (lukaszlenart: rev 8bf77a1d19d31dbc8574dcbf958c3da2a4724c84)
          • (add) core/src/test/java/com/opensymphony/xwork2/util/StrutsLocalizedTextProviderTest.java
          • (edit) core/src/main/java/com/opensymphony/xwork2/config/impl/DefaultConfiguration.java
          • (delete) core/src/test/java/com/opensymphony/xwork2/util/DefaultLocalizedTextProviderTest.java
          • (edit) core/src/main/java/com/opensymphony/xwork2/config/providers/XWorkConfigurationProvider.java
          • (edit) core/src/main/resources/struts-default.xml
          • (delete) core/src/main/java/com/opensymphony/xwork2/util/DefaultLocalizedTextProvider.java
          • (add) core/src/main/java/com/opensymphony/xwork2/util/StrutsLocalizedTextProvider.java
            WW-4762 Extracts base abstract class (lukaszlenart: rev 2e23d7a07ea4313136dc38b8de2451b04c882064)
          • (edit) core/src/main/java/com/opensymphony/xwork2/util/StrutsLocalizedTextProvider.java
          • (add) core/src/main/java/com/opensymphony/xwork2/util/AbstractLocalizedTextProvider.java
            WW-4762 Introduces default provider which only uses default bundles (lukaszlenart: rev bb19a6209886795b76385e48fd86424c144ee029)
          • (add) core/src/main/java/com/opensymphony/xwork2/util/DefaultLocalizedTextProvider.java
          • (edit) core/src/main/java/com/opensymphony/xwork2/util/AbstractLocalizedTextProvider.java
          • (edit) core/src/main/java/com/opensymphony/xwork2/util/StrutsLocalizedTextProvider.java
            WW-4762 Moves common method up (lukaszlenart: rev 7360b5e1956f415866c189d7adda861456d4d069)
          • (edit) core/src/main/java/com/opensymphony/xwork2/util/AbstractLocalizedTextProvider.java
          • (edit) core/src/main/java/com/opensymphony/xwork2/util/StrutsLocalizedTextProvider.java
            WW-4762 Extracts common method (lukaszlenart: rev fd168c423f70383a6240cba9809a87b661ef39de)
          • (edit) core/src/main/java/com/opensymphony/xwork2/util/DefaultLocalizedTextProvider.java
          • (edit) core/src/main/java/com/opensymphony/xwork2/util/StrutsLocalizedTextProvider.java
          • (edit) core/src/main/java/com/opensymphony/xwork2/util/AbstractLocalizedTextProvider.java
            WW-4762 Defines default-only bean (lukaszlenart: rev 4604333649a0060421c07cd5520c8285ca0c135f)
          • (edit) core/src/main/resources/struts-default.xml
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Struts-JDK7-master #631 (See https://builds.apache.org/job/Struts-JDK7-master/631/ ) WW-4762 Drops unused code (lukaszlenart: rev 45d1a491311a82f6b2404d839e7e18269a26192f) (edit) core/src/main/java/org/apache/struts2/util/StrutsTestCaseHelper.java WW-4762 Drops unused imports (lukaszlenart: rev 3ffc9b8450845d7a90a623607e3b4bb05888e2f9) (edit) core/src/test/java/org/apache/struts2/config/PropertiesConfigurationProviderTest.java (edit) core/src/main/java/org/apache/struts2/dispatcher/Dispatcher.java (edit) core/src/main/java/com/opensymphony/xwork2/DefaultTextProvider.java WW-4762 Uses Struts prefix for the main implementation (lukaszlenart: rev 8bf77a1d19d31dbc8574dcbf958c3da2a4724c84) (add) core/src/test/java/com/opensymphony/xwork2/util/StrutsLocalizedTextProviderTest.java (edit) core/src/main/java/com/opensymphony/xwork2/config/impl/DefaultConfiguration.java (delete) core/src/test/java/com/opensymphony/xwork2/util/DefaultLocalizedTextProviderTest.java (edit) core/src/main/java/com/opensymphony/xwork2/config/providers/XWorkConfigurationProvider.java (edit) core/src/main/resources/struts-default.xml (delete) core/src/main/java/com/opensymphony/xwork2/util/DefaultLocalizedTextProvider.java (add) core/src/main/java/com/opensymphony/xwork2/util/StrutsLocalizedTextProvider.java WW-4762 Extracts base abstract class (lukaszlenart: rev 2e23d7a07ea4313136dc38b8de2451b04c882064) (edit) core/src/main/java/com/opensymphony/xwork2/util/StrutsLocalizedTextProvider.java (add) core/src/main/java/com/opensymphony/xwork2/util/AbstractLocalizedTextProvider.java WW-4762 Introduces default provider which only uses default bundles (lukaszlenart: rev bb19a6209886795b76385e48fd86424c144ee029) (add) core/src/main/java/com/opensymphony/xwork2/util/DefaultLocalizedTextProvider.java (edit) core/src/main/java/com/opensymphony/xwork2/util/AbstractLocalizedTextProvider.java (edit) core/src/main/java/com/opensymphony/xwork2/util/StrutsLocalizedTextProvider.java WW-4762 Moves common method up (lukaszlenart: rev 7360b5e1956f415866c189d7adda861456d4d069) (edit) core/src/main/java/com/opensymphony/xwork2/util/AbstractLocalizedTextProvider.java (edit) core/src/main/java/com/opensymphony/xwork2/util/StrutsLocalizedTextProvider.java WW-4762 Extracts common method (lukaszlenart: rev fd168c423f70383a6240cba9809a87b661ef39de) (edit) core/src/main/java/com/opensymphony/xwork2/util/DefaultLocalizedTextProvider.java (edit) core/src/main/java/com/opensymphony/xwork2/util/StrutsLocalizedTextProvider.java (edit) core/src/main/java/com/opensymphony/xwork2/util/AbstractLocalizedTextProvider.java WW-4762 Defines default-only bean (lukaszlenart: rev 4604333649a0060421c07cd5520c8285ca0c135f) (edit) core/src/main/resources/struts-default.xml
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Struts-JDK7-master #632 (See https://builds.apache.org/job/Struts-JDK7-master/632/)
          WW-4762 Uses global to better express the meaning (lukaszlenart: rev 3a9f86a605354c80ded30b3f47524dff1456d3a1)

          • (edit) core/src/main/resources/struts-default.xml
          • (delete) core/src/main/java/com/opensymphony/xwork2/util/DefaultLocalizedTextProvider.java
          • (add) core/src/main/java/com/opensymphony/xwork2/util/GlobalLocalizedTextProvider.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Struts-JDK7-master #632 (See https://builds.apache.org/job/Struts-JDK7-master/632/ ) WW-4762 Uses global to better express the meaning (lukaszlenart: rev 3a9f86a605354c80ded30b3f47524dff1456d3a1) (edit) core/src/main/resources/struts-default.xml (delete) core/src/main/java/com/opensymphony/xwork2/util/DefaultLocalizedTextProvider.java (add) core/src/main/java/com/opensymphony/xwork2/util/GlobalLocalizedTextProvider.java

            People

            • Assignee:
              lukaszlenart Lukasz Lenart
              Reporter:
              ghuber Greg Huber
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development