Uploaded image for project: 'Struts 2'
  1. Struts 2
  2. WW-4747

s:file generates input tag with "value" attribute

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.x, 2.5
    • Fix Version/s: 2.5.12
    • Component/s: Core Tags
    • Labels:
      None

      Description

      <s:file> tag generates HTML tag like:
      <input type="file" ... value="" .../>

      It is valid as long as the empty "value" value was specified, but HTML5 standard says:
      "The element's value attribute must be omitted."
      https://www.w3.org/TR/html5/forms.html#file-upload-state-(type=file)

        Issue Links

          Activity

          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit f487d7e7d69c767949a59f36ceb5a45d96eb32dd in struts's branch refs/heads/master from Aleksandr Mashchenko
          [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=f487d7e ]

          WW-4747 s:file generates input tag with "value" attribute

          Show
          jira-bot ASF subversion and git services added a comment - Commit f487d7e7d69c767949a59f36ceb5a45d96eb32dd in struts's branch refs/heads/master from Aleksandr Mashchenko [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=f487d7e ] WW-4747 s:file generates input tag with "value" attribute
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Struts-JDK7-master #599 (See https://builds.apache.org/job/Struts-JDK7-master/599/)
          WW-4747 s:file generates input tag with "value" attribute (amashchenko: rev f487d7e7d69c767949a59f36ceb5a45d96eb32dd)

          • (edit) core/src/test/resources/org/apache/struts2/views/jsp/ui/File-1.txt
          • (edit) core/src/test/java/org/apache/struts2/views/jsp/ui/FileTest.java
          • (edit) core/src/main/resources/template/simple/file.ftl
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Struts-JDK7-master #599 (See https://builds.apache.org/job/Struts-JDK7-master/599/ ) WW-4747 s:file generates input tag with "value" attribute (amashchenko: rev f487d7e7d69c767949a59f36ceb5a45d96eb32dd) (edit) core/src/test/resources/org/apache/struts2/views/jsp/ui/File-1.txt (edit) core/src/test/java/org/apache/struts2/views/jsp/ui/FileTest.java (edit) core/src/main/resources/template/simple/file.ftl
          Show
          yasser.zamani Yasser Zamani added a comment - Aleksandr Mashchenko , you may be interested in a similar issue at Struts2 generates value=“Submit” which the W3C markup validator says is an error .
          Hide
          aleksandr-m Aleksandr Mashchenko added a comment -
          Show
          aleksandr-m Aleksandr Mashchenko added a comment - Yasser Zamani WW-4630

            People

            • Assignee:
              aleksandr-m Aleksandr Mashchenko
              Reporter:
              kzmi Iwasa Kazmi
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development