Uploaded image for project: 'Struts 2'
  1. Struts 2
  2. WW-4743

NPE in StrutsTilesContainerFactory when resource isn't found

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5.10
    • Fix Version/s: 2.5.12
    • Component/s: Plugin - Tiles
    • Labels:
      None

      Description

      When using org.apache.tiles.definition.DefinitionsFactory.DEFINITIONS_CONFIG with the path to resource that is missing, NPE is being thrown in that line in StrutsTilesContainerFactory.

        Activity

        Hide
        aleksandr-m Aleksandr Mashchenko added a comment -

        Null check with warn log if resource is null? Wdyt?

        Show
        aleksandr-m Aleksandr Mashchenko added a comment - Null check with warn log if resource is null? Wdyt?
        Hide
        lukaszlenart Lukasz Lenart added a comment -

        You are right, null-check + warn is the way to go

        Show
        lukaszlenart Lukasz Lenart added a comment - You are right, null-check + warn is the way to go
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit a399932ae9903167d1ee647b141cc98fdf83ef6f in struts's branch refs/heads/master from Aleksandr Mashchenko
        [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=a399932 ]

        WW-4743 NPE in StrutsTilesContainerFactory when resource isn't found

        Show
        jira-bot ASF subversion and git services added a comment - Commit a399932ae9903167d1ee647b141cc98fdf83ef6f in struts's branch refs/heads/master from Aleksandr Mashchenko [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=a399932 ] WW-4743 NPE in StrutsTilesContainerFactory when resource isn't found
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Struts-JDK7-master #594 (See https://builds.apache.org/job/Struts-JDK7-master/594/)
        WW-4743 NPE in StrutsTilesContainerFactory when resource isn't found (amashchenko: rev a399932ae9903167d1ee647b141cc98fdf83ef6f)

        • (edit) plugins/tiles/src/main/java/org/apache/struts2/tiles/StrutsTilesContainerFactory.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Struts-JDK7-master #594 (See https://builds.apache.org/job/Struts-JDK7-master/594/ ) WW-4743 NPE in StrutsTilesContainerFactory when resource isn't found (amashchenko: rev a399932ae9903167d1ee647b141cc98fdf83ef6f) (edit) plugins/tiles/src/main/java/org/apache/struts2/tiles/StrutsTilesContainerFactory.java

          People

          • Assignee:
            aleksandr-m Aleksandr Mashchenko
            Reporter:
            aleksandr-m Aleksandr Mashchenko
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development