Uploaded image for project: 'Struts 2'
  1. Struts 2
  2. WW-4735

EmailValidator does not accept new domain suffixes

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.3.33, 2.5.10
    • Component/s: None
    • Labels:
      None

      Description

      I don't think Struts should be validating domain suffixes, because they can be purchased now. The work to add them to this EMAIL_ADDRESS_PATTERN will grow exponential

      Currently I added ".swiss" to my already customised email regex and this will not be the last one...

      I suggest to use a more flexible regex for this.

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 45580718ab01627d4cf2b168e65e4d0016681a54 in struts's branch refs/heads/master from Lukasz Lenart
        [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=4558071 ]

        WW-4735 Uses more flexible RegExp to match domain suffixes

        Show
        jira-bot ASF subversion and git services added a comment - Commit 45580718ab01627d4cf2b168e65e4d0016681a54 in struts's branch refs/heads/master from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=4558071 ] WW-4735 Uses more flexible RegExp to match domain suffixes
        Hide
        lukaszlenart Lukasz Lenart added a comment -

        Done, I have added more flexible RegExp to match suffixes, thanks

        Show
        lukaszlenart Lukasz Lenart added a comment - Done, I have added more flexible RegExp to match suffixes, thanks
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Struts-JDK7-master #587 (See https://builds.apache.org/job/Struts-JDK7-master/587/)
        WW-4735 Uses more flexible RegExp to match domain suffixes (lukaszlenart: rev 45580718ab01627d4cf2b168e65e4d0016681a54)

        • (edit) core/src/main/java/com/opensymphony/xwork2/validator/validators/EmailValidator.java
        • (edit) core/src/test/java/com/opensymphony/xwork2/validator/EmailValidatorTest.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Struts-JDK7-master #587 (See https://builds.apache.org/job/Struts-JDK7-master/587/ ) WW-4735 Uses more flexible RegExp to match domain suffixes (lukaszlenart: rev 45580718ab01627d4cf2b168e65e4d0016681a54) (edit) core/src/main/java/com/opensymphony/xwork2/validator/validators/EmailValidator.java (edit) core/src/test/java/com/opensymphony/xwork2/validator/EmailValidatorTest.java
        Hide
        samized Samuel Zihlmann added a comment -

        Thanks! Is it possible to merge this fix into 2.3.x branch?

        Show
        samized Samuel Zihlmann added a comment - Thanks! Is it possible to merge this fix into 2.3.x branch?
        Hide
        lukaszlenart Lukasz Lenart added a comment -

        I can but it won't happen too soon (a new release)

        Show
        lukaszlenart Lukasz Lenart added a comment - I can but it won't happen too soon (a new release)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit c349dfa5abb6f6072304eca3d679d6f2dd448f52 in struts's branch refs/heads/support-2-3 from Lukasz Lenart
        [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=c349dfa ]

        WW-4735 Ports more relax domain suffix validation

        Show
        jira-bot ASF subversion and git services added a comment - Commit c349dfa5abb6f6072304eca3d679d6f2dd448f52 in struts's branch refs/heads/support-2-3 from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=c349dfa ] WW-4735 Ports more relax domain suffix validation
        Hide
        lukaszlenart Lukasz Lenart added a comment -

        Ported to 2.3.x

        Show
        lukaszlenart Lukasz Lenart added a comment - Ported to 2.3.x
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Jenkins build Struts-JDK6-support-2.3 #1058 (See https://builds.apache.org/job/Struts-JDK6-support-2.3/1058/)
        WW-4735 Ports more relax domain suffix validation (lukaszlenart: rev c349dfa5abb6f6072304eca3d679d6f2dd448f52)

        • (edit) xwork-core/src/main/java/com/opensymphony/xwork2/validator/validators/EmailValidator.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Jenkins build Struts-JDK6-support-2.3 #1058 (See https://builds.apache.org/job/Struts-JDK6-support-2.3/1058/ ) WW-4735 Ports more relax domain suffix validation (lukaszlenart: rev c349dfa5abb6f6072304eca3d679d6f2dd448f52) (edit) xwork-core/src/main/java/com/opensymphony/xwork2/validator/validators/EmailValidator.java

          People

          • Assignee:
            lukaszlenart Lukasz Lenart
            Reporter:
            samized Samuel Zihlmann
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development