Uploaded image for project: 'Struts 2'
  1. Struts 2
  2. WW-4715

Scope interceptor always resets because of org.apache.struts2.dispatcher.HttpParameters

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.5.5
    • Fix Version/s: 2.5.8
    • Component/s: Core Interceptors
    • Labels:
      None

      Description

      Line 302 of org.apache.struts2.interceptor.ScopeInterceptor performs a not-null check to see if a session reset parameter exists by calling com.opensymphony.xwork2.ActionContext.getParameters().get(...).

      The return type of getParameters() is org.apache.struts2.dispatcher.HttpParameters, and HttpParamters.get() never returns null on a missing parameter, causing the not-null check to always evaluate to true.

      This breaks the interceptor by short circuiting the scoped variable injection.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              xxbeanxx Greg Baker
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: