Uploaded image for project: 'Struts 2'
  1. Struts 2
  2. WW-4714

Convert LocalizedTextUtil into a bean with default implementation

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.5.5
    • Fix Version/s: 2.5.12
    • Component/s: Core
    • Labels:
      None

      Description

      It's a followup of WW-4464 and PR #50

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user lukaszlenart opened a pull request:

          https://github.com/apache/struts/pull/121

          WW-4714: Localized bean

          This PR converts existing static util class `LocalizedTextUtil` into an injectable bean, which will allow to have multiple implementations.

          Depends on #120
          Issue WW-4714

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/lukaszlenart/struts localized-bean

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/struts/pull/121.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #121


          commit b3b8b909e39f403dd76ce349ca546c7dff627e1a
          Author: Lukasz Lenart <lukaszlenart@apache.org>
          Date: 2017-03-07T10:26:22Z

          Converts into a bean

          commit ae09c6a0878ea3beac58567b58cfbdea261f4945
          Author: Lukasz Lenart <lukaszlenart@apache.org>
          Date: 2017-03-08T16:41:42Z

          Defines LocalizedTextUtil as a bean

          commit fa1a5f9e6927ab7521c30366631e128371d41277
          Author: Lukasz Lenart <lukaszlenart@apache.org>
          Date: 2017-03-08T16:42:13Z

          Adds LocalizedTextUtil as a bean

          commit 239327ea363e020af0a0de2669bc2e991bfe6bfb
          Author: Lukasz Lenart <lukaszlenart@apache.org>
          Date: 2017-03-08T16:42:42Z

          Marks static methods as deprecated

          commit 4ef641850539557ffbc9412ff1d6627a8e08fd32
          Author: Lukasz Lenart <lukaszlenart@apache.org>
          Date: 2017-03-08T16:43:20Z

          Injects instead of static reference

          commit 2733f158d892efb2febdd99fc1772ed6564ea7be
          Author: Lukasz Lenart <lukaszlenart@apache.org>
          Date: 2017-03-08T16:43:28Z

          Updates test

          commit 524343c3cf79faad15e49fc26221de308853cbfc
          Author: Lukasz Lenart <lukaszlenart@apache.org>
          Date: 2017-03-08T16:45:32Z

          Moves default bean name to common place

          commit 741f3fa107eee331209e52477c1a007bfc5db755
          Author: Lukasz Lenart <lukaszlenart@apache.org>
          Date: 2017-03-08T16:52:01Z

          Marks param as a deprecated

          commit 0b16543d6f5d48c3b2739871b7af609bf7b658b5
          Author: Lukasz Lenart <lukaszlenart@apache.org>
          Date: 2017-03-08T16:52:24Z

          Drops support for Xwork xml configuration

          commit 442a52fe48745bc03b3d6b15e74a01cdf0c9f6a1
          Author: Lukasz Lenart <lukaszlenart@apache.org>
          Date: 2017-03-09T08:43:38Z

          Marks deprecated constructor

          commit 1ab616b10b2c43052bd8806e6e08fc0772de8b8a
          Author: Lukasz Lenart <lukaszlenart@apache.org>
          Date: 2017-03-09T08:44:07Z

          Marks deprecated constructor

          commit 6c19875c786c03a33658f633d5c6a3425bbd5aaf
          Author: Lukasz Lenart <lukaszlenart@apache.org>
          Date: 2017-03-09T09:19:12Z

          Puts back the default bean name to allow alias beans

          commit da5da67d8027ad2fd05e579c893a4a8a8acd728e
          Author: Lukasz Lenart <lukaszlenart@apache.org>
          Date: 2017-03-10T07:39:20Z

          Makes factory fully injectable

          commit db8ebe710d1aaa815006d070b9dda4930a9d152a
          Author: Lukasz Lenart <lukaszlenart@apache.org>
          Date: 2017-03-10T07:39:55Z

          Uses the new injectable factory to obtain TextProvider

          commit 728055dc46b2517791d5860d60a77e6196ddcbaf
          Author: Lukasz Lenart <lukaszlenart@apache.org>
          Date: 2017-03-10T07:40:24Z

          Adjust usage of the factory

          commit 89d95b64cd68b0b7d03f60249f6202dbb2e14b28
          Author: Lukasz Lenart <lukaszlenart@apache.org>
          Date: 2017-03-10T08:17:03Z

          Drops empty line

          commit 3be5aa0fdb23a69f7dabf3633ca8dd5d09f923dc
          Author: Lukasz Lenart <lukaszlenart@apache.org>
          Date: 2017-03-10T08:17:25Z

          Adds missing constructor param

          commit d7cf0609059c7ffe1f90cc044c9ea20536e823b2
          Author: Lukasz Lenart <lukaszlenart@apache.org>
          Date: 2017-03-10T08:20:39Z

          Defines new injectable bean with alias

          commit 3dc8480988f38f367f9965bad0ff60656d091fa9
          Author: Lukasz Lenart <lukaszlenart@apache.org>
          Date: 2017-03-10T08:20:57Z

          Updates test

          commit c063704d279b6dc7d349c232f17b3b2aebe19b99
          Author: Lukasz Lenart <lukaszlenart@apache.org>
          Date: 2017-03-10T08:21:24Z

          Renames class to match its purpose

          commit 57106ccda2207edb52e575e16cfd47599e9c7110
          Author: Lukasz Lenart <lukaszlenart@apache.org>
          Date: 2017-03-10T08:21:28Z

          Renames class to match its purpose

          commit 451eb883070100dfc57c7635ddc80c57f82f8169
          Author: Lukasz Lenart <lukaszlenart@apache.org>
          Date: 2017-03-10T08:37:19Z

          Adds missing anntoation to properly inject dependency

          commit f56c59c9829347255f5b161ac97dc51069b61fed
          Author: Lukasz Lenart <lukaszlenart@apache.org>
          Date: 2017-03-10T08:37:36Z

          Defines TextProviderFactory as a bean

          commit 55ea82cd4faaecf1f3ca1fffd4428db2471b952d
          Author: Lukasz Lenart <lukaszlenart@apache.org>
          Date: 2017-03-10T08:40:20Z

          Uses container to inject required dependencies

          commit 2b3082ee40360740b8d5221cc08cc428043e5caf
          Author: Lukasz Lenart <lukaszlenart@apache.org>
          Date: 2017-03-13T05:45:37Z

          Uses more direct message to link with proper resource bundle

          commit 664895a338a2079233b92d211b91be33a5f586ea
          Author: Lukasz Lenart <lukaszlenart@apache.org>
          Date: 2017-03-13T05:47:03Z

          Creates dedicated TextProvider for given class

          commit ce2261f6f590b4ab963ba815d40c02736171437a
          Author: Lukasz Lenart <lukaszlenart@apache.org>
          Date: 2017-03-13T05:47:11Z

          Drops static

          commit 6d60064bea0481b684bf284ebea285c33684ca3b
          Author: Lukasz Lenart <lukaszlenart@apache.org>
          Date: 2017-03-13T05:51:47Z

          Injects missing dependency

          commit 8852e3d1183f1ce18dbf8dc9bb1da465eaa9f1c3
          Author: Lukasz Lenart <lukaszlenart@apache.org>
          Date: 2017-03-13T05:56:07Z

          Injects missing dependency

          commit d1fbf6a8972908fac3a41ec0e2756fe4eec1afb6
          Author: Lukasz Lenart <lukaszlenart@apache.org>
          Date: 2017-03-13T07:20:42Z

          Merge branch 'injectable-context' into localized-bean


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user lukaszlenart opened a pull request: https://github.com/apache/struts/pull/121 WW-4714 : Localized bean This PR converts existing static util class `LocalizedTextUtil` into an injectable bean, which will allow to have multiple implementations. Depends on #120 Issue WW-4714 You can merge this pull request into a Git repository by running: $ git pull https://github.com/lukaszlenart/struts localized-bean Alternatively you can review and apply these changes as the patch at: https://github.com/apache/struts/pull/121.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #121 commit b3b8b909e39f403dd76ce349ca546c7dff627e1a Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-07T10:26:22Z Converts into a bean commit ae09c6a0878ea3beac58567b58cfbdea261f4945 Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-08T16:41:42Z Defines LocalizedTextUtil as a bean commit fa1a5f9e6927ab7521c30366631e128371d41277 Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-08T16:42:13Z Adds LocalizedTextUtil as a bean commit 239327ea363e020af0a0de2669bc2e991bfe6bfb Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-08T16:42:42Z Marks static methods as deprecated commit 4ef641850539557ffbc9412ff1d6627a8e08fd32 Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-08T16:43:20Z Injects instead of static reference commit 2733f158d892efb2febdd99fc1772ed6564ea7be Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-08T16:43:28Z Updates test commit 524343c3cf79faad15e49fc26221de308853cbfc Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-08T16:45:32Z Moves default bean name to common place commit 741f3fa107eee331209e52477c1a007bfc5db755 Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-08T16:52:01Z Marks param as a deprecated commit 0b16543d6f5d48c3b2739871b7af609bf7b658b5 Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-08T16:52:24Z Drops support for Xwork xml configuration commit 442a52fe48745bc03b3d6b15e74a01cdf0c9f6a1 Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-09T08:43:38Z Marks deprecated constructor commit 1ab616b10b2c43052bd8806e6e08fc0772de8b8a Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-09T08:44:07Z Marks deprecated constructor commit 6c19875c786c03a33658f633d5c6a3425bbd5aaf Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-09T09:19:12Z Puts back the default bean name to allow alias beans commit da5da67d8027ad2fd05e579c893a4a8a8acd728e Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-10T07:39:20Z Makes factory fully injectable commit db8ebe710d1aaa815006d070b9dda4930a9d152a Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-10T07:39:55Z Uses the new injectable factory to obtain TextProvider commit 728055dc46b2517791d5860d60a77e6196ddcbaf Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-10T07:40:24Z Adjust usage of the factory commit 89d95b64cd68b0b7d03f60249f6202dbb2e14b28 Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-10T08:17:03Z Drops empty line commit 3be5aa0fdb23a69f7dabf3633ca8dd5d09f923dc Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-10T08:17:25Z Adds missing constructor param commit d7cf0609059c7ffe1f90cc044c9ea20536e823b2 Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-10T08:20:39Z Defines new injectable bean with alias commit 3dc8480988f38f367f9965bad0ff60656d091fa9 Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-10T08:20:57Z Updates test commit c063704d279b6dc7d349c232f17b3b2aebe19b99 Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-10T08:21:24Z Renames class to match its purpose commit 57106ccda2207edb52e575e16cfd47599e9c7110 Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-10T08:21:28Z Renames class to match its purpose commit 451eb883070100dfc57c7635ddc80c57f82f8169 Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-10T08:37:19Z Adds missing anntoation to properly inject dependency commit f56c59c9829347255f5b161ac97dc51069b61fed Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-10T08:37:36Z Defines TextProviderFactory as a bean commit 55ea82cd4faaecf1f3ca1fffd4428db2471b952d Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-10T08:40:20Z Uses container to inject required dependencies commit 2b3082ee40360740b8d5221cc08cc428043e5caf Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-13T05:45:37Z Uses more direct message to link with proper resource bundle commit 664895a338a2079233b92d211b91be33a5f586ea Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-13T05:47:03Z Creates dedicated TextProvider for given class commit ce2261f6f590b4ab963ba815d40c02736171437a Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-13T05:47:11Z Drops static commit 6d60064bea0481b684bf284ebea285c33684ca3b Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-13T05:51:47Z Injects missing dependency commit 8852e3d1183f1ce18dbf8dc9bb1da465eaa9f1c3 Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-13T05:56:07Z Injects missing dependency commit d1fbf6a8972908fac3a41ec0e2756fe4eec1afb6 Author: Lukasz Lenart <lukaszlenart@apache.org> Date: 2017-03-13T07:20:42Z Merge branch 'injectable-context' into localized-bean
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/struts/pull/121

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/struts/pull/121
          Hide
          lukaszlenart Lukasz Lenart added a comment -

          PR got merged

          Show
          lukaszlenart Lukasz Lenart added a comment - PR got merged

            People

            • Assignee:
              lukaszlenart Lukasz Lenart
              Reporter:
              lukaszlenart Lukasz Lenart
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development