[WW-4674] StrutsPrepareAndExecuteFilter should check for response commited status

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.3.30
• Fix Version/s: 2.3.31, 2.5.5
• Assignee: Unassigned
• Reporter: Mirek Hankus
• Created: 01/Aug/16 15:16
• Updated: 13/Feb/17 09:52
• Resolved: 16/Sep/16 14:38

Description

In StrutsPrepareAndExecuteFilter in doFilter method there is a code fragment

ActionMapping mapping = this.prepare.findActionMapping(request, response, true);
if(mapping == null) {
    boolean handled = this.execute.executeStaticResourceRequest(request, response);
    if(!handled) {
           chain.doFilter(request, response);
    }
} else {
    this.execute.executeAction(request, response, mapping);
}

Problem is that this.prepare.findActionMapping(request, response, true) can commit response (in case of exception), but filter continues with execution of chain, in my case causing problems up in the chain.