[WW-4592] The ScopedModelDriven Interceptor is not thread safe ?

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Not A Problem
• Fix Version/s: 2.5.x
• Component/s: Core Interceptors
• Assignee: Unassigned
• Reporter: Andrea Ligios
• Created: 19/Jan/16 18:05
• Updated: 19/Jan/16 22:39
• Resolved: 19/Jan/16 22:39

Description

Looking at the source code of the ScopedModelDriven Interceptor, I can see the following variables scoped at class level:

     private String scope;
     private String name;
     private String className;
     private ObjectFactory objectFactory;

https://github.com/apache/struts/blob/master/core/src/main/java/com/opensymphony/xwork2/interceptor/ScopedModelDrivenInterceptor.java#L85-L88

AFAIK, this means they're not thread safe, since different requests could override those variables altering the workflow of other threads.

Even if it's not that easy for it to happen, it seems just wrong.

And by the way, what's the problem on having those defined at method level, and settle things once and for all ?