Uploaded image for project: 'Struts 2'
  1. Struts 2
  2. WW-4568

Upgrade Tiles 2 to latest available Tiles 2 version

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.24
    • Fix Version/s: 2.3.28
    • Component/s: Plugin - Tiles
    • Labels:
      None

      Activity

      Hide
      githubbot ASF GitHub Bot added a comment -

      GitHub user lukaszlenart opened a pull request:

      https://github.com/apache/struts/pull/59

      Upgrade tiles plugin

      Fixes WW-4568

      This PR upgrades the Tiles Plugin and adjusts its API to be compatible with Tiles 2.2.2 - this allows introduce support for OGNL, EL, Wildcards and so on.

      You can merge this pull request into a Git repository by running:

      $ git pull https://github.com/lukaszlenart/struts upgrade-tiles-plugin

      Alternatively you can review and apply these changes as the patch at:

      https://github.com/apache/struts/pull/59.patch

      To close this pull request, make a commit to your master/trunk branch
      with (at least) the following in the commit message:

      This closes #59


      commit 85b219813f982ad28059197c6ebcb0b099f7e4b3
      Author: Lukasz Lenart <lukasz.lenart@gmail.com>
      Date: 2015-11-25T19:22:31Z

      Adds required dependencies

      commit 70716e945295526d207cab6c66306a3113f8a333
      Author: Lukasz Lenart <lukasz.lenart@gmail.com>
      Date: 2015-11-25T19:29:18Z

      Re-implements tiles integration based on new API

      commit 24a5bce6c436ddaea9f65f792b280fdd6f9c4ae3
      Author: Lukasz Lenart <lukasz.lenart@gmail.com>
      Date: 2015-11-25T19:29:24Z

      Drops unused classes

      commit 26f153d262f7a4dfb767c391afece8ac1d9e1c0d
      Author: Lukasz Lenart <lukasz.lenart@gmail.com>
      Date: 2015-11-25T19:29:43Z

      Replaces call to deprecated api

      commit 6edc0ff5e0410651f7055654116c3346aeaa4ee5
      Author: Lukasz Lenart <lukasz.lenart@gmail.com>
      Date: 2015-11-25T19:37:42Z

      Updates Portal Tiles integration


      Show
      githubbot ASF GitHub Bot added a comment - GitHub user lukaszlenart opened a pull request: https://github.com/apache/struts/pull/59 Upgrade tiles plugin Fixes WW-4568 This PR upgrades the Tiles Plugin and adjusts its API to be compatible with Tiles 2.2.2 - this allows introduce support for OGNL, EL, Wildcards and so on. You can merge this pull request into a Git repository by running: $ git pull https://github.com/lukaszlenart/struts upgrade-tiles-plugin Alternatively you can review and apply these changes as the patch at: https://github.com/apache/struts/pull/59.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #59 commit 85b219813f982ad28059197c6ebcb0b099f7e4b3 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-11-25T19:22:31Z Adds required dependencies commit 70716e945295526d207cab6c66306a3113f8a333 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-11-25T19:29:18Z Re-implements tiles integration based on new API commit 24a5bce6c436ddaea9f65f792b280fdd6f9c4ae3 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-11-25T19:29:24Z Drops unused classes commit 26f153d262f7a4dfb767c391afece8ac1d9e1c0d Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-11-25T19:29:43Z Replaces call to deprecated api commit 6edc0ff5e0410651f7055654116c3346aeaa4ee5 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-11-25T19:37:42Z Updates Portal Tiles integration
      Hide
      githubbot ASF GitHub Bot added a comment -

      GitHub user lukaszlenart opened a pull request:

      https://github.com/apache/struts/pull/60

      Struts 2.3.x: Tiles plugin upgrade

      Fixes WW-4568(https://issues.apache.org/jira/browse/WW-4568)

      This PR upgrades the Tiles Plugin and adjusts its API to be compatible with Tiles 2.2.2 - this allows introduce support for OGNL, EL, Wildcards and so on.

      You can merge this pull request into a Git repository by running:

      $ git pull https://github.com/lukaszlenart/struts tiles-plugin-upgrade-struts-2-3

      Alternatively you can review and apply these changes as the patch at:

      https://github.com/apache/struts/pull/60.patch

      To close this pull request, make a commit to your master/trunk branch
      with (at least) the following in the commit message:

      This closes #60


      commit 1dc545e34c19520c0ba780b43c53a28f5e3e9484
      Author: Lukasz Lenart <lukasz.lenart@gmail.com>
      Date: 2015-11-25T19:22:31Z

      Adds required dependencies
      (cherry picked from commit 85b2198)

      commit 9862580bbee704cff63b917f3dfda62d21c1bad5
      Author: Lukasz Lenart <lukasz.lenart@gmail.com>
      Date: 2015-11-25T19:29:18Z

      Re-implements tiles integration based on new API
      (cherry picked from commit 70716e9)

      commit efcea81b67d260835eff9c811efe20a816df7213
      Author: Lukasz Lenart <lukasz.lenart@gmail.com>
      Date: 2015-11-25T19:29:24Z

      Drops unused classes
      (cherry picked from commit 24a5bce)

      commit 5d30eb1ad21d369a5e5e844363f3ec1e0e93d03a
      Author: Lukasz Lenart <lukasz.lenart@gmail.com>
      Date: 2015-11-25T19:29:43Z

      Replaces call to deprecated api
      (cherry picked from commit 26f153d)

      commit ddeb7f0f7cc2600ceb36b8532fc433861a38c20e
      Author: Lukasz Lenart <lukasz.lenart@gmail.com>
      Date: 2015-11-25T19:37:42Z

      Updates Portal Tiles integration
      (cherry picked from commit 6edc0ff)

      commit 913944b8eee6c5565cb665b5477953be9b85152a
      Author: Lukasz Lenart <lukasz.lenart@gmail.com>
      Date: 2015-11-25T19:54:39Z

      Adds missing header with license
      (cherry picked from commit 27ad6cb)

      commit f19e4be947c00511a91ea2d806c9c483694f7485
      Author: Lukasz Lenart <lukasz.lenart@gmail.com>
      Date: 2015-11-27T12:36:52Z

      Registers Tiles model
      (cherry picked from commit 388861f)

      commit 27aa7e1e27546effcfc1e4214d231b4a31263fb5
      Author: Lukasz Lenart <lukasz.lenart@gmail.com>
      Date: 2015-11-28T14:39:47Z

      Fixes dependency clash

      (cherry picked from commit 6622fab25bee1dae9085cca56b87711f3197916d)

      Conflicts:
      apps/showcase/pom.xml
      plugins/bean-validation/pom.xml


      Show
      githubbot ASF GitHub Bot added a comment - GitHub user lukaszlenart opened a pull request: https://github.com/apache/struts/pull/60 Struts 2.3.x: Tiles plugin upgrade Fixes WW-4568 ( https://issues.apache.org/jira/browse/WW-4568 ) This PR upgrades the Tiles Plugin and adjusts its API to be compatible with Tiles 2.2.2 - this allows introduce support for OGNL, EL, Wildcards and so on. You can merge this pull request into a Git repository by running: $ git pull https://github.com/lukaszlenart/struts tiles-plugin-upgrade-struts-2-3 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/struts/pull/60.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #60 commit 1dc545e34c19520c0ba780b43c53a28f5e3e9484 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-11-25T19:22:31Z Adds required dependencies (cherry picked from commit 85b2198) commit 9862580bbee704cff63b917f3dfda62d21c1bad5 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-11-25T19:29:18Z Re-implements tiles integration based on new API (cherry picked from commit 70716e9) commit efcea81b67d260835eff9c811efe20a816df7213 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-11-25T19:29:24Z Drops unused classes (cherry picked from commit 24a5bce) commit 5d30eb1ad21d369a5e5e844363f3ec1e0e93d03a Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-11-25T19:29:43Z Replaces call to deprecated api (cherry picked from commit 26f153d) commit ddeb7f0f7cc2600ceb36b8532fc433861a38c20e Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-11-25T19:37:42Z Updates Portal Tiles integration (cherry picked from commit 6edc0ff) commit 913944b8eee6c5565cb665b5477953be9b85152a Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-11-25T19:54:39Z Adds missing header with license (cherry picked from commit 27ad6cb) commit f19e4be947c00511a91ea2d806c9c483694f7485 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-11-27T12:36:52Z Registers Tiles model (cherry picked from commit 388861f) commit 27aa7e1e27546effcfc1e4214d231b4a31263fb5 Author: Lukasz Lenart <lukasz.lenart@gmail.com> Date: 2015-11-28T14:39:47Z Fixes dependency clash (cherry picked from commit 6622fab25bee1dae9085cca56b87711f3197916d) Conflicts: apps/showcase/pom.xml plugins/bean-validation/pom.xml
      Hide
      githubbot ASF GitHub Bot added a comment -

      Github user lukaszlenart closed the pull request at:

      https://github.com/apache/struts/pull/59

      Show
      githubbot ASF GitHub Bot added a comment - Github user lukaszlenart closed the pull request at: https://github.com/apache/struts/pull/59
      Hide
      victorsosa victorsosa added a comment - - edited

      Hi Lukasz Lenart,

      you commited this code already :+1:

      Show
      victorsosa victorsosa added a comment - - edited Hi Lukasz Lenart, you commited this code already :+1:
      Hide
      lukaszlenart Lukasz Lenart added a comment -

      It's still under review, one issue left

      Show
      lukaszlenart Lukasz Lenart added a comment - It's still under review, one issue left
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 997966829ae3bac1bf490daf30e56415aa84aec5 in struts's branch refs/heads/support-2-3 from Lukasz Lenart
      [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=9979668 ]

      WW-4568 Upgrades the Tiles plugin to Tiles 2

      Show
      jira-bot ASF subversion and git services added a comment - Commit 997966829ae3bac1bf490daf30e56415aa84aec5 in struts's branch refs/heads/support-2-3 from Lukasz Lenart [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=9979668 ] WW-4568 Upgrades the Tiles plugin to Tiles 2
      Hide
      githubbot ASF GitHub Bot added a comment -

      Github user asfgit closed the pull request at:

      https://github.com/apache/struts/pull/60

      Show
      githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/struts/pull/60
      Show
      lukaszlenart Lukasz Lenart added a comment - PR merged, docs update and example added https://cwiki.apache.org/confluence/display/WW/Tiles+2+Plugin https://github.com/apache/struts-examples/tree/master/tiles

        People

        • Assignee:
          lukaszlenart Lukasz Lenart
          Reporter:
          lukaszlenart Lukasz Lenart
        • Votes:
          0 Vote for this issue
          Watchers:
          4 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development