[WW-4528] ChainingInterceptor does not handle lists correctly for excludes and includes

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.3.24
• Fix Version/s: 2.5.12
• Component/s: Core Interceptors
• Assignee: Unassigned
• Reporter: nikos dimitrakas
• Created: 22/Jul/15 08:55
• Updated: 13/Jul/17 19:28
• Resolved: 14/Feb/17 07:07

Description

The ChainingInterceptor has two parameters includes and excludes that according to the documentation and the code are Collection<String>, but the setters don't handle the specified values (that are loaded from the struts.xml) as lists. So if i specify for example
<interceptor-ref name="chain">
<param name="includes">x,y,z</param>
</interceptor-ref>
the includes variable of the interceptor becomes a Collection of one string with the value "x,y,z" instead of a Collection of three strings "x", "y" and "z".
The behaviour should instead be similar to the ParametersInterceptor's excludeParams or MethodFilterInterceptor's excludeMethods and includeMethods.

It would also be good if the documentation included information and an example with a list of parameters. The current documentation (https://struts.apache.org/docs/chaining-interceptor.html) only says that the parameters are lists, but the example only has one parameter

Issue Links

• links to: GitHub Pull Request #116