[WW-4508] DefaultActionMapperTest failures due to invalid mock type for parameterMap

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 2.3.24
• Fix Version/s: 6.5.0
• Component/s: Unit Tests

Environment

The JVM where this was encountered is the Waratek JVM (www.waratek.com) which contains support for prevention of SQL Injection attacks. This bug is not reproducible using OpenJDK or any other JVM due to the fact the tests reference only the keys and not the values.

• Assignee: Unassigned
• Reporter: Dermot McGahon
• Created: 29/May/15 11:41
• Updated: 06/Apr/24 16:46

Description

All of the tests which use StrutsMockHttpServletRequest are setting up incorrectly typed parameterMaps in the mock.

A parameterMap should be typed java.util.Map<java.lang.String,java.lang.String[]> and not Map<String,String> as the tests are doing i.e the value parameter should be String[] and not String. This caused us to see test failures when treating those values as String[] when they weren't.

See:

http://docs.oracle.com/javaee/6/api/javax/servlet/ServletRequest.html
http://docs.oracle.com/javaee/7/api/javax/servlet/ServletRequest.html#getParameterMap%28%29