Uploaded image for project: 'Struts 2'
  1. Struts 2
  2. WW-4486

Default parameter exclusions blocking legitimate values

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.3.20
    • Fix Version/s: 2.3.24
    • Component/s: Core Interceptors
    • Labels:
      None

      Description

      In ParametersInterceptor.setParameters(), when building acceptableParameters(), it applies the check isAcceptableValue not just just to the parameter name, but also to the parameter value. This is a huge problem because the default excludedPatterns include phrases that will come up in normal user form submissions.

      For example, the way I discovered this is that one pattern is "(.\.|^|.|[('|"))\bclass(\.|('|")]|[).*"

      We are a car site, so when a user tried to post a message about a Mercedes M class: "That's M class. You asked for G class, different beast!"

      The "class." at the end of the first sentence was rejected and so their post failed.

      What is the reason for applying the exclusion patterns wholesale to the parameter value? Is it even necessary at all, or is there some kind of escape character that normally tells ognl to evaluate an expression in the value, in which case we could check for exclusion pattern matches just within those?

      As it is though, the current solution is going to cause some occasional very peculiar behavior for developers. Not sure if this should actually be a blocker bug since the only reasonable workaround seems to be to hack the ParametersInterceptor locally (since one shouldn't remove the exclusion patterns in general).

        Attachments

          Activity

            People

            • Assignee:
              lukaszlenart Lukasz Lenart
              Reporter:
              perfnorm Jasper Rosenberg
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: