Uploaded image for project: 'Struts 2'
  1. Struts 2
  2. WW-4452

s:optiontransferselect javascript functions no longer work with negative integer keys

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.20
    • Fix Version/s: 2.3.24
    • Component/s: None
    • Labels:
      None

      Description

      It appears that the change made to fix WW-4365 broke the javascript functions used to implement onclick handlers for the s:optiontransferselect tag.

      While attempting an upgrade to 2.3.20 from 2.3.16.3, all pages containing tags like the following are broken (tests fail):

      <s:optiontransferselect multiple="true" headerKey="-1" doubleHeaderKey="-1" multiple="true" doubleMultiple="true" addAllToRightOnclick="selectAllOptionsExceptSome(document.getElementById('saveBuildDefinitionTemplate_selectedBuildDefinitionIds'), 'key', '-1');" />
      

      Since the regular expression used to match the header keys now always attempts to match on word boundary, the change introduced in WW-4365, it will not match negative numbers like '-1'. This is likely to break a number of applications since the struts 2 documentation for optiontransferselect suggests using '-1'.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                lukaszlenart Lukasz Lenart
                Reporter:
                batkinson Brent Atkinson
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: