[WW-4318] Logging message when OgnlValueStack fail to set expression is cryptic most of the time

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 2.3.16.1
• Fix Version/s: 2.3.20
• Component/s: Value Stack
• Labels: logging
• Flags: Patch
• Assignee: Lukasz Lenart
• Reporter: Brendan Le Ny
• Created: 08/Apr/14 15:13
• Updated: 13/Jan/15 11:58
• Resolved: 28/Jul/14 19:02

Description

Most of the time, the logging message printed by OgnlValueStack class is useless because it doesn't show the value that causes the problem.

Exemple log:

2014/03/20 02:23:28 WARN (CommonsLogger.java:64) warn Error setting expression 'myIntField' with value '[Ljava.lang.String;@55227e4a'
ognl.MethodFailedException: Method "setMyIntField" failed for object fr.my.company.MyAction@df39b8b4 [java.lang.NoSuchMethodException: [e-mail]([Ljava.lang.String;)]

I can't find the reason because toString() is on a array show '[Ljava.lang.String;@55227e4a' but i would like to see the actual value in the array.

The exact same problem is fixed right in the method above the buggy one: the trivial patch is included.