[WW-4244] ShowConfigAction.execute() throws InstantiationException when the Action has NO nullary constructor

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.3.15.3
• Fix Version/s: 2.3.20
• Component/s: Plugin - Config Browser
• Assignee: Lukasz Lenart
• Reporter: Harry Chan
• Created: 18/Nov/13 01:58
• Updated: 13/Jan/15 11:58
• Resolved: 15/Jan/14 08:13

Description

In my case, I use Guice for DI and constructor injection is used in many Actions.
When I enable the Config Browser feature and click the Action in the Action information page, it shows the error message

Unable to execute org.apache.struts2.config_browser.ShowConfigAction

After a brief code tracing, I found that in the ShowConfigAction.execute(), it uses clazz.newInstance() for creating the action instance. And the java-doc of the newInstance() claims that it would throw the InstantiationException if the class has no nullary constructor.

I think one of the quick fix would be added default-constructor into those Actions(I have tested it and it works). However, I think it would not be a good solution as the extra constructor is a redundancy to me and would increase the maintenance cost.

I am wondering if the ShowConfigAction could use ObjectFactory.buildBean() for creating the action instance.

P.S: Please correct me if I use the Config Browser Plugin in the wrong way.