[WW-4171] getText methods are not documented as evaluating OGNL

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.3.15.1
• Fix Version/s: 2.5.8
• Component/s: Documentation
• Labels: security
• Flags: Important
• Assignee: Lukasz Lenart
• Reporter: Coverity Security Research Laboratory
• Created: 05/Aug/13 17:48
• Updated: 13/Feb/17 09:52
• Resolved: 12/Nov/16 17:04

Description

The methods below evaluate OGNL as their first parameter. However they are not documented as evaluating OGNL. We have observed this occurring in one project and are contacting the affected vendors.

com.opensymphony.xwork2.TextProviderSupport.getText(String, String[])
com.opensymphony.xwork2.TextProviderSupport.getText(String, List<?>)
com.opensymphony.xwork2.TextProviderSupport.getText(String)

These methods are then used by ActionSupport (via its getText methods). None of these methods are documented as evaluating OGNL either.

This issue is recommending that all of these methods are documented as evaluating OGNL since this may come as a surprise to some developers.

Issue Links

• is related to: WW-2760 Annotation-based Parameters Interceptor