[WW-4131] RestActionProxyFactory is handling all requests with PrefixBasedActionMapper

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.3.12, 2.3.14, 2.3.15
• Fix Version/s: 2.3.16
• Component/s: Plugin - REST
• Assignee: Lukasz Lenart
• Reporter: Felipe Lorenz
• Created: 27/Jun/13 20:20
• Updated: 18/Dec/17 09:00
• Resolved: 23/Oct/13 07:47

Description

Using the following configuration:

<constant name="struts.mapper.class" value="org.apache.struts2.dispatcher.mapper.PrefixBasedActionMapper"/>
<constant name="struts.mapper.prefixMapping" value=":rest,/ajax:struts,/login:struts"/>

Is expected that when I request the following url http://xxxxxxxx.com/ajax/anyThingHere, struts action proxy should handle this call. But instead, RestActionProxyFactory is handling this call.

But the RestActionProxyFactory class has a if, and every time the namespace attribute is injected with "/ajax" value. So the condition always is redirected to the rest plugin handler and not to the struts default.

Here is my ActionProxyFactory implementation:

public class CustomActionProxyFactory extends RestActionProxyFactory {

    @Override
    public ActionProxy createActionProxy(String namespace, String actionName, String methodName, Map<String, Object> extraContext, boolean executeResult, boolean cleanupContext) {
        RestActionProxyFactory p = new RestActionProxyFactory();
        p.setContainer(container);
        if ("/ajax".equals(namespace)) {
            p.setNamespace("/idealogic");
        }
        return p.createActionProxy(namespace, actionName, methodName, extraContext, executeResult, cleanupContext);
    }
}

By some reason, it fixed the origin behaviour.

The begin of this issue was that <s:action> tag was rendering the action result, even with executeResult = false, which is the default value.

Another observation was that, changing the flush attribute value, the result is rendered in different parts of the html.

Issue Links

• relates to: WW-4903 Dependency Mapping Exception When Using PrefixBasedActionProxyFactory