[WW-4126] Incorrect behavior for ELSupport.containsNulls()

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.3.14.3
• Fix Version/s: 2.3.16
• Component/s: Plugin - Embedded JSP
• Labels: patch

Environment

any

• Flags: Patch, Important
• Assignee: Bruce Allen Phillips
• Reporter: Adrian Nistor
• Created: 21/Jun/13 21:32
• Updated: 08/Dec/13 17:21
• Resolved: 17/Jul/13 15:10

Description

The incorrect behavior appears in version 2.3.14.3 and in revision
1495522. I attached a one-line patch (patch.diff) that fixes it.

Method "ELSupport.containsNulls" checks if the "Object[] obj" array
contains nulls like this:

for (int i = 0; i < obj.length; i++) {
    if (obj[0] == null) {
        return true;
    }
}
return false;

Instead of "obj[0]", the code should be "obj[i]", as in patch.diff.

If indeed the code is intended to check only "obj[0]", then there is
no need for a loop and the entire method body should be only "return
obj[0] == null;" (I attached patch2.diff, though it's unlikely that
this is the correct behavior).