Uploaded image for project: 'Struts 2'
  1. Struts 2
  2. WW-3953

ParametersInterceptor fills log with unneeded warnings

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.8
    • Fix Version/s: 2.3.12
    • Component/s: Core Interceptors
    • Labels:
      None
    • Environment:

      all

      Description

      ParametersInterceptor.java fills the log with unneeded warnings such this:

      Parameter [username] is not on the excludeParams list of patterns and will be appended to action!

      The cause of the problem is that normally (when a POSTed value matches acceptParamNames, but not excludeParams), the isExcluded() method will be called, which logs every match and not-match.

      The logging happens with the notifyDeveloper() method of the class, which logs as WARNING in devmode, and DEBUG if not.

      I suppose to lower this always to DEBUG, and maybe the notifyDeveloper() method should even be gone.

      have a nice day,

      PH

        Attachments

          Activity

            People

            • Assignee:
              lukaszlenart Lukasz Lenart
              Reporter:
              hap Peter Horvath
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: