Struts 2
  1. Struts 2
  2. WW-3860

Restrict accepted parameter name length

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.4
    • Fix Version/s: 2.3.4.1
    • Component/s: Core Interceptors
    • Labels:
      None

      Description

      Long parameter names are costly to evaluate for OGNL and should be limited to a reasonable length, in our case 100 characters.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        1h 47m 1 Rene Gielen 03/Aug/12 11:42
        Resolved Resolved Closed Closed
        86d 11h 29m 1 Lukasz Lenart 28/Oct/12 22:11
        Lukasz Lenart made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Rene Gielen made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 2.3.4.1 [ 12322543 ]
        Fix Version/s 2.3.5 [ 12321274 ]
        Resolution Fixed [ 1 ]
        Hide
        Rene Gielen added a comment -

        Johno's patch applied.

        Show
        Rene Gielen added a comment - Johno's patch applied.
        Hide
        Hudson added a comment -

        Integrated in Struts2 #516 (See https://builds.apache.org/job/Struts2/516/)
        WW-3860
        Restrict accepted parameter name length
        Thanks to Johno Crawford for the patch. (Revision 1368841)

        Result = SUCCESS
        rgielen :
        Files :

        • /struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/interceptor/ParametersInterceptor.java
        • /struts/struts2/trunk/xwork-core/src/test/java/com/opensymphony/xwork2/interceptor/ParametersInterceptorTest.java
        Show
        Hudson added a comment - Integrated in Struts2 #516 (See https://builds.apache.org/job/Struts2/516/ ) WW-3860 Restrict accepted parameter name length Thanks to Johno Crawford for the patch. (Revision 1368841) Result = SUCCESS rgielen : Files : /struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/interceptor/ParametersInterceptor.java /struts/struts2/trunk/xwork-core/src/test/java/com/opensymphony/xwork2/interceptor/ParametersInterceptorTest.java
        Rene Gielen created issue -

          People

          • Assignee:
            Rene Gielen
            Reporter:
            Rene Gielen
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development