[WW-3696] XWork-Core JUnit Test Failure: com.opensymphony.xwork2.validator.DefaultValidatorFileParserTest.testParserWithBadXML2( )

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 2.3.1
• Component/s: Other, Unit Tests
• Labels: dtd junit parse xwork
• Flags: Patch
• Assignee: Maurizio Cucchiara
• Reporter: JB
• Created: 01/Nov/11 21:51
• Updated: 08/Dec/11 19:54
• Resolved: 01/Nov/11 22:19

Description

When I ran the tests on XWork-Core project the following test was failing:

    com.opensymphony.xwork2.validator.DefaultValidatorFileParserTest.testParserWithBadXML2()

The XML file the test attempts to validate is:

    com.opensymphony.xwork2.validator.validators-fail.xml

The DTD information contained within the validators-fail.xml file is:

    <!DOCTYPE validators PUBLIC
        "-//Apache Struts//XWork Validator Config 1.0//EN"
        "http://struts.apache.org/dtds/xwork-validator-config-1.0.dtd">

However...

In class com.opensymphony.xwork2.validator.DefaultValidatorFileParser and method parseActionValidatorConfigs()...

The above DTD is not present.

After adding the DTD to the parseActionValidatorConfigs method, the test succeeds. In fact 100% of the tests then succeed.

I performed a search on JIRA and did not find anything related to this item; therefore I am creating this issue.