[WW-3694] JSONResult - buildSMDObject method is never called internally

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.2.3.1
• Fix Version/s: 2.3.1
• Component/s: Plugin - JSON

Environment

Tomcat on windows, JDK1.5

• Assignee: Maurizio Cucchiara
• Reporter: Alex Yavorskiy
• Created: 25/Oct/11 15:49
• Updated: 08/Dec/11 19:54
• Resolved: 26/Oct/11 15:06

Description

Pre version 2.2.3.1 JSONResult object used to have a protected method that allowed us to have a subclass that could modify URL of the SMD command being sent in the response right before it was sent. That method was "writeSMD". In version 2.2.3.1 of Struts there is no more method named "writeSMD", but there appears to be equivalent protected method named "buildSMDObject". However, we observed that buildSMDObject is never called by the infrastructure, so there is no use overriding it.

After inspecting source for JSONResult, it looks like line 180 in the readRootObject function is really intended to call buildSMDObject. However, instead of calling the protected method in question, it creates SMD object right there.

if (enableSMD)

{ return new SMDGenerator(root, excludeProperties, ignoreInterfaces).generate(invocation); }

Fixing line 180 to call buildSMDObject should fix the issue. We had to significantly re-write our subclass for JSONResult to work around the deficiency. Hope this can be fixed in a future release.

Issue Links

• is related to: WW-3509 JSONResult.setIncludeProperties() constructs incorrect patterns