Struts 2
  1. Struts 2
  2. WW-3653

Struts2 should base on JDK5 and all tests must passing

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Blocker Blocker
    • Resolution: Unresolved
    • Affects Version/s: 2.2.3
    • Fix Version/s: 3.0
    • Component/s: Core Actions
    • Labels:
      None

      Description

      testFailsOnMethodThatThrowsException(com.opensymphony.xwork2.ognl.OgnlValueStack
      Test)

      Tests run: 657, Failures: 1, Errors: 0, Skipped: 0

      [INFO] ------------------------------------------------------------------------
      [INFO] BUILD FAILURE
      [INFO] ------------------------------------------------------------------------
      [INFO] Total time: 38.547s
      [INFO] Finished at: Tue Jun 07 10:05:56 EDT 2011
      [INFO] Final Memory: 10M/37M
      [INFO] ------------------------------------------------------------------------
      [ERROR] Failed to execute goal
      org.apache.maven.plugins:maven-surefire-plugin:2.6:test (default-test) on
      project xwork-core: There are test failures.
      [ERROR]
      [ERROR] Please refer to C:\Documents and Settings\All
      Users\Desktop\projects\struts\struts2\trunk\xwork-core\target\surefire-reports
      for the individual test results.
      [ERROR] -> [Help 1]
      [ERROR]
      [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
      switch.
      [ERROR] Re-run Maven using the -X switch to enable full debug logging.
      [ERROR]
      [ERROR] For more information about the errors and possible solutions, please
      read the following articles:
      [ERROR] [Help 1]
      http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

      jpyeron@reclaimed /projects/struts/struts2/trunk/xwork-core
      $

      public void testFailsOnMethodThatThrowsException() {
      SimpleAction action = new SimpleAction();
      OgnlValueStack stack = createValueStack();
      stack.push(action);

      action.setThrowException(true);
      try

      { stack.findValue("exceptionMethod1()", true); fail("Failed to throw exception on EL method exception"); }

      catch (Exception ex)

      { //ok }

      }

        Activity

        Hide
        Rene Gielen added a comment -

        +1 to ditch 1.4 support, yes

        Show
        Rene Gielen added a comment - +1 to ditch 1.4 support, yes
        Hide
        Lukasz Lenart added a comment -

        With the current company we're using 1.6, in the previous company 1.4

        At least we should discard support for 1.4

        Show
        Lukasz Lenart added a comment - With the current company we're using 1.6, in the previous company 1.4 At least we should discard support for 1.4
        Hide
        Rene Gielen added a comment -

        I'm not sure we should require Java 6 for users currently. Been to various BigCos recently, lot's are still nailed to J5, regardless it's support has ended. What are your experiences?

        Show
        Rene Gielen added a comment - I'm not sure we should require Java 6 for users currently. Been to various BigCos recently, lot's are still nailed to J5, regardless it's support has ended. What are your experiences?
        Hide
        Lukasz Lenart added a comment -

        We should consider switching to JDK 1.6

        Show
        Lukasz Lenart added a comment - We should consider switching to JDK 1.6
        Hide
        Hudson added a comment -

        Integrated in Struts2 #328 (See https://builds.apache.org/job/Struts2/328/)

        Show
        Hudson added a comment - Integrated in Struts2 #328 (See https://builds.apache.org/job/Struts2/328/ )
        Hide
        Lukasz Lenart added a comment -

        Ok, lets switch and discuss on dev@ ML

        Show
        Lukasz Lenart added a comment - Ok, lets switch and discuss on dev@ ML
        Hide
        Maurizio Cucchiara added a comment -
        Show
        Maurizio Cucchiara added a comment - Otherwise we could also consider using the Animal Sniffer Maven Plugin [1] Take also a look at [2] [1] http://mojo.codehaus.org/animal-sniffer-maven-plugin/examples/checking-signatures.html [2] http://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-source-and-target.html
        Hide
        Maurizio Cucchiara added a comment -

        I'm wondering if maven compiler plugin could be useful.
        Anyway we cannot definitely continue to use java 5 settings in Jenkins, so if there is no objections, I would be going to restore the original settings.

        Show
        Maurizio Cucchiara added a comment - I'm wondering if maven compiler plugin could be useful. Anyway we cannot definitely continue to use java 5 settings in Jenkins, so if there is no objections, I would be going to restore the original settings.
        Hide
        Maurizio Cucchiara added a comment -

        Now the xwork module passes every tests.
        There are some troubles with gxp and embedded jsp plugins:
        the former depends on google gxp library which was compiled with Java 6, the latter uses the javax.tools package, introduced also with Java 6.
        For the gxp plugin, considering the external dependency, there is no way to be compiled with Java 5.

        Any thoughts?

        Show
        Maurizio Cucchiara added a comment - Now the xwork module passes every tests. There are some troubles with gxp and embedded jsp plugins: the former depends on google gxp library which was compiled with Java 6, the latter uses the javax.tools package, introduced also with Java 6. For the gxp plugin, considering the external dependency, there is no way to be compiled with Java 5. Any thoughts?
        Hide
        Maurizio Cucchiara added a comment -

        The test was totally wrong since it was order dependant.
        Java 5 with maven (neither Idea nor eclipse fail the test) ran the test in a different order.
        The class CompundRootAccessor use a static cache for the invalid methods which is obviously sensitive to the test execution order.
        Keep your finger crossed

        Show
        Maurizio Cucchiara added a comment - The test was totally wrong since it was order dependant. Java 5 with maven (neither Idea nor eclipse fail the test) ran the test in a different order. The class CompundRootAccessor use a static cache for the invalid methods which is obviously sensitive to the test execution order. Keep your finger crossed

          People

          • Assignee:
            Lukasz Lenart
            Reporter:
            Lukasz Lenart
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:

              Development