Struts 2
  1. Struts 2
  2. WW-3529

In xwork-core, NamedVariablePatternMatcher does not properly escape characters

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 2.2.1
    • Fix Version/s: 3.0
    • Component/s: Other
    • Labels:
      None
    • Flags:
      Patch

      Description

      The com.opensymphony.xwork2.util.NamedVariablePatternMatcher class has a bug in the compilePattern(String) method. The purpose of the method is to compile patterns such as "action/

      {foo}

      " to a regular expression Pattern and extract the variable names that match each group in the regex. In the example given and the 2.2.1 code base, the pattern will be compiled as "action/([^/]+)". However, if the pattern includes characters that have special meaning to Java's regular expression engine, they are currently not being escaped.

      For example, the pattern "action.

      {format}" is being compiled to "action.([^/]+)" which correctly matches "action.html" but also "actionK.html" or any other character because the '.' is not escaped. The bug really bites when a pattern like "{name}.{format}

      " is used. This will be compiled to "([^/]).([^/])" which will match "cars.html" but not the way you expect. Because of greediness, it will set name = "cars.ht" and format = "l".

      I will submit a patch to fix this behavior on the next screen.

        Activity

        No work has yet been logged on this issue.

          People

          • Assignee:
            Unassigned
            Reporter:
            Richard Vermillion
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:

              Development