[WW-3490] FileUploadInterceptor should clean up even if action throws exception

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.2.1
• Fix Version/s: 2.2.3
• Component/s: Core Interceptors

Environment

Independent of environment

• Flags: Patch
• Assignee: John Lindal
• Reporter: John Lindal
• Created: 01/Sep/10 20:55
• Updated: 28/Oct/12 22:13
• Resolved: 31/Jan/11 20:46

Description

In Struts 2.2.1 (and also in trunk), org.apache.struts2.interceptor.FileUploadInterceptor cleans up uploaded files after the action finishes. The first problem is that the action might throw an exception. FileUploadInterceptor does not use try...finally, so any action exception will result in files not being cleaned up. The second problem is that something earlier in the interceptor stack might throw an exception, in which case FileUploadInterceptor will not even be invoked. The correct solution is for FilterDispatcher to clean up the uploaded files.