[WW-3462] connection open after report generation

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1.8
• Fix Version/s: 2.3.28, 2.5
• Component/s: Plugin - JasperReports

Environment

jdk1.5.0_16

• Flags: Patch
• Assignee: Unassigned
• Reporter: Salva
• Created: 30/Jun/10 13:07
• Updated: 15/Jul/16 14:11
• Resolved: 04/Jan/16 19:21

Description

If a report generation was called with connection like following code, database connection will not be closed. I suggest to modify doExecute method of org.apache.struts2.views.jasperreports.JasperReportsResult class after the exportReportToBytes, by adding, in case of conn not null, the conn closing.

struts.xml
...
<action name="report" class="myorg.actions.tests.Report">
<result name="success" type="jasper">
<param name="location">/test/Report.jasper</param>
<param name="connection">myConnection</param>
<param name="contentDisposition">attachment</param>
<param name="format">PDF</param>
</result>
</action>
....

Action execute method code
...
DataSource ds = (DataSource) ictx.lookup("java:jdbc/myApp");
myConnection = ds.getConnection();
...