[WW-3460] Use look-before-you-leap strategy for creating Spring beans vs Struts objects

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1.6
• Fix Version/s: 2.2.3
• Component/s: Plugin - Spring
• Flags: Patch
• Assignee: Lukasz Lenart
• Reporter: Leigh Anderson
• Created: 28/Jun/10 09:17
• Updated: 28/Oct/12 22:07
• Resolved: 23/Oct/10 20:03

Description

For our use case with struts actions and validators, each page request resulted in the SpringObjectFactory.buildBean() method being called multiple times for the validator beans which were known ahead of time not to be spring-managed. This results in an exception being thrown and caught – effectively using exceptions as flow control. The attached patch checks the Spring context before delegating the bean creation.

In our tests, this resulted in a reduction in both CPU use and request latency.