[WW-3385] (Application|Session|Request)Map.put(key,value) breaks Map-contract, returning new value, not old value

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 2.1.8.1
• Fix Version/s: 2.2.1
• Component/s: Dispatch Filter
• Assignee: Lukasz Lenart
• Reporter: Erling Molde
• Created: 17/Feb/10 16:02
• Updated: 28/Oct/12 22:13
• Resolved: 18/Feb/10 13:46

Description

Noticed that the Map-wrapper classes (org.apache.struts2.dispatcher.RequestMap etc.) returns the new value from put-method.

request.setAttribute(key.toString(), value);
return get(key);

Should be:

V value = get(key);
request.setAttribute(key.toString(), value);
return value;

in order to be consistent with other Map-implementations.