[WW-3291] Update sitemesh-plugin to use version 2.4.2. (CLONE, CATCHALL).

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.1.6, 2.1.8
• Fix Version/s: 2.2.1
• Component/s: Plugin - SiteMesh

Environment

JDK 1.5+, Struts 2.1.6+ & SiteMesh 2.4+

• Flags: Patch
• Assignee: Lukasz Lenart
• Reporter: Christian Wolfgang Stone
• Created: 21/Oct/09 16:28
• Updated: 25/Mar/14 06:46
• Resolved: 16/Mar/10 14:47

Description

Catch-all bug for the following bugs: WW-3116 (marked as resolved, not fixed), WW-1128 (should now work on 2.4 and lower), WW-3275 (very good description),

Detailed description of this issue can be found in the following discussion thread.
http://www.nabble.com/Struts-2.1.8-%2B-SiteMesh-2.4.2-%2B-FreeMarkerPageFilter-Broken-td25721587.html

I am attaching a patch that updates the struts2-sitemesh plugin to use the more current SiteMeshPageFilter.java class. The old code was deprecated and deleted from the sitemesh with the 2.4.2 release!

The new files are as follows. I am testing the freemarker extensively, and will test the velocity a bit later. Please test both and let me know if there are any problems.

FreeMarkerMapper2DecoratorSelector.java OldDecorator2NewStrutsDecorator.java VelocityMapper2DecoratorSelector.java
FreeMarkerPageFilter.java OldDecorator2NewStrutsFreemarkerDecorator.java VelocityPageFilter.java
NoneDecoratorMapper.java OldDecorator2NewStrutsVelocityDecorator.java

Issue Links

• breaks: WW-3330 <@s.action> broken in sitemesh freemarker decorator page
• is depended upon by: WW-3116 Update sitemesh-plugin to use version 2.4.2 (GAE compliancy)
• is duplicated by: WW-3275 FreeMarkerPageFilter broken in struts-sitemesh-plugin 2.1.8
• is part of: WW-3296 Full integration with SiteMesh 2 + Freemarker 2.4.2 + Velocity 1.3 , including struts tags, value stack, and FreemarkerManager statics.