Uploaded image for project: 'Struts 2'
  1. Struts 2
  2. WW-3215

ActionComponent swallows exceptions

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.1.6, 2.1.8
    • 2.1.8
    • Other
    • None
    • Freemarker

    Description

      We render sub-portions of our pages using s.action. Unfortunately, when one of these fails, rather than ending up with a 500 error (and in our own error/exception handling code), the user gets a partially rendered page. This is because ActionComponent.executeAction() catches and logs all exceptions, but never rethrows them:

      } catch (Exception e) {
      String message = "Could not execute action: " + namespace + "/" + actualName;
      LOG.error(message, e);
      }

      There could be a parameter added of course to request that exceptions be swallowed for case where a partial render might be fine, or executeResult is false and they don't care if it fails, but it does seem like that would be better handled explicitly in the action being invoked instead.

      Attachments

        Activity

          People

            wesw@wantii.com Wes Wannemacher
            perfnorm Jasper Rosenberg
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: