[WW-3075] StrutsPrepareAndExecuteFilter accesses request parameters before setting request encoding

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1.6
• Fix Version/s: 2.1.8
• Component/s: Dispatch Filter
• Flags: Patch
• Assignee: Unassigned
• Reporter: Roman Shevchenko
• Created: 05/Apr/09 14:23
• Updated: 28/Oct/12 22:07
• Resolved: 18/Apr/09 17:24

Description

In StrutsPrepareAndExecuteFilter.doFilter(), method PrepareOperations.createActionContext() is called before PrepareOperations.setEncodingAndLocale() one. This causes population of value stack with incorrect data. Same problem exists in StrutsPrepareFilter.

Suggested patch:
— StrutsPrepareAndExecuteFilter.java Mon Jan 05 20:00:24 2009
+++ StrutsPrepareAndExecuteFilter.java Sun Apr 05 18:01:18 2009
@@ -62,9 +62,9 @@
HttpServletResponse response = (HttpServletResponse) res;

try {
+ prepare.setEncodingAndLocale(request, response);
prepare.createActionContext(request, response);
prepare.assignDispatcherToThread();

• prepare.setEncodingAndLocale(request, response);
  request = prepare.wrapRequest(request);
  ActionMapping mapping = prepare.findActionMapping(request, response);
  if (mapping == null) {

— StrutsPrepareFilter.java Mon Jan 05 20:00:24 2009
+++ StrutsPrepareFilter.java Sun Apr 05 18:01:34 2009
@@ -56,9 +56,9 @@
HttpServletResponse response = (HttpServletResponse) res;

try {
+ prepare.setEncodingAndLocale(request, response);
prepare.createActionContext(request, response);
prepare.assignDispatcherToThread();

• prepare.setEncodingAndLocale(request, response);
  request = prepare.wrapRequest(request);
  prepare.findActionMapping(request, response);

Issue Links

• is duplicated by: WW-3179 StrutsPrepareAndExecuteFilter and StrutsPrepareFilter causes i18n problems