Details
-
Bug
-
Status: Closed
-
Major
-
Resolution: Fixed
-
2.0.11.1
-
None
-
Struts 2.0.11.1, Tiles 2.0.6, Tiles Plugin 2.0.11.1
-
Patch
Description
When i try to use Tiles in Portlet environment using the above versions, it does not work. I have done some research and these are my findings.
( Step 1) CODE BASE - TILES PLUGIN 2.0.11.1
In org.apache.struts2.tiles.StrutsTilesRequestContext, this logic is such that it always calls dispatch(), if mask is not ending with ".ftl".
public void dispatch(String include) throws IOException {
if (include.endsWith(mask))
else
{ super.dispatch(include); }}
( Step 2) CODE BASE - TILES 2.0.6
super.dispatch() in the above code calls org.apache.tiles.servlet.context.ServletTilesRequestContext.dispatch()
public void dispatch(String path) throws IOException {
if (response.isCommitted() || ServletUtil.isForceInclude(request))
else
{ forward(path); }}
Atleast above logic should have worked to call include(), if ServletUtil.isForceInclude(request) returned true.
ServletUtil.isForceInclude(request) returns true if request.getAttribute(ServletUtil.FORCE_INCLUDE_ATTRIBUTE_NAME) = =true.
( Step 3) CODE BASE - STRUTS 2.0.11.1
Call to org.apache.struts2.portlet.servlet.PortletServletRequestDispatcher.doForward() throws IllegalStateException.
public void forward(ServletRequest request, ServletResponse response) throws ServletException, IOException
{ throw new IllegalStateException("Not allowed in a portlet"); }My guess is, forward() should not be called when the result is of type TilesResult.
My guess is that we need a fix in Step 1.
EITHER
call super.include() instead of calling dispatch()
OR
request.setAttribute("org.apache.tiles.servlet.context.ServletTilesRequestContext.FORCE_INCLUDE", new Boolean(true)) before calling super.dispatch().
Thanks,
Sridhar.
Attachments
Attachments
Issue Links
- is related to
-
WW-2749 portlet plugin doesn't work with tiles
- Closed