Uploaded image for project: 'Struts 2'
  1. Struts 2
  2. WW-2656

Support for Validation of Indexed Properties

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Won't Do
    • 2.0.11
    • None
    • Core Interceptors
    • None

    Description

      Currently, there doesn't seem to be a method of validating an indexed property (ie. a collection) directly or indirecetly within an action.

      For instance, given an action OrderAction with a property order of type Order where order contains a collection trades of type Trade, the following is not possible:

      @Validation
      public class OrderAction {
      	private Order order = new Order();
      
      	@Validations(requiredFields = {
      		@RequiredFieldValidator(message = "", key = "errors.required", fieldName = "order.trades[].field1"),
      		@RequiredFieldValidator(message = "", key = "errors.required", fieldName = "order.trades[].field2"),
      	})	
      	public String execute() throws Exception {
      	     ....
              }
      

      The closest thing to support for something like the above is using the VisitorFieldValidator validator. Although it has the following disadvantages:
      1. It must be placed on the target object (invasive and not context sensitive)
      2. It does not work with an indirect collection (as in the example above)

      Something like this should be possible (even struts1 validator supports indexedListProperty)

      On a related topic, it should be possible to do the following to display the error in the resulting view:

      <s:fielderror><s:param>order.trades[2].field1</s:param></s:fielderror>
      

      Attachments

        Activity

          People

            Unassigned Unassigned
            btiernay Bob Tiernay
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: