[WW-2581] add generics to RequestAware, SessionAware, and ParameterAware

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.1.2
• Component/s: Core Interceptors
• Assignee: Donald J. Brown
• Reporter: Brad Cupit
• Created: 07/Apr/08 20:43
• Updated: 28/Oct/12 22:11
• Resolved: 20/Apr/08 03:27

Description

Since Struts2 targets Java 1.5, it would be great if RequestAware, SessionAware, and ParameterAware could be updated to use generics.

Each defines a setter which takes a Map, but the Map does not use generics.

Problem:
When implementing these methods, developers must add a @SuppressWarnings("unchecked") to the method to compile without warnings.

Suggested fix: change the method signatures to use generics.

RequestAware.setRequest(Map<String, Object> request);
SessionAware.setSession(Map<String, Object> session);
ParameterAware.setParameters(Map<String, String[]> parameters);