[WW-2511] i18n tag never calls getTexts(bundleName) of TextProvider

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.11, 2.1.1
• Fix Version/s: 2.1.1
• Component/s: Other
• Assignee: Unassigned
• Reporter: Jeromy Evans
• Created: 26/Feb/08 22:16
• Updated: 28/Oct/12 22:11
• Resolved: 26/Feb/08 22:51

Description

The i18n tag uses the following code to invoke the getTexts(bundleName) method using a TextProvider in the ValueStack:

ResourceBundle bundle = (ResourceBundle) findValue("texts('" + name + "')");

This never works. It should read:

ResourceBundle bundle = (ResourceBundle) findValue("getTexts('" + name + "')");

The code would have only occasionally caused problems as the tag calls LocalizedTextUtil.findResourceBundle(name...) anyway when the line above failed.

For the record, I think calling methods by embedding non-typesafe expressions in code is a bad idea.