[WW-2504] Request get parameters are included into the result URL even though the request is PortletRequest

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1.0
• Fix Version/s: 2.1.2
• Component/s: "New" API, Plugin - Portlet, Plugin - Tags

Environment

Struts 2.1.0, xwork 2.1.0, struts2-portlet-plugin-2.1.0. Custom portlal implementation.

• Assignee: Nils-Helge Garli
• Reporter: Vladimir Limansky
• Created: 22/Feb/08 21:15
• Updated: 28/Oct/12 22:08
• Resolved: 25/Apr/08 08:33

Description

Request get parameters are included to the portlet url. Portlet specification says that only setParameter method should be used to add parameters while building portlet URLs.

Consider org.apache.struts2.components.URL

Let's compare the following methods:
1. Struts 2.0.9 code:

private void includeGetParameters() {
if(!(Dispatcher.getInstance().isPortletSupportActive() && PortletActionContext.isPortletRequest()))

{ String query = extractQueryString(); mergeRequestParameters(value, parameters, UrlHelper.parseQueryString(query)); }

}
Pay attention, that parameters are not included in case of portlet request.

2. Struts 2.1.0 code:

private void includeGetParameters()

{ String query = extractQueryString(); mergeRequestParameters(value, parameters, UrlHelper.parseQueryString(query)); }

The parameters are always included.