[WW-1777] DateTimePicker doesn't support expressions in the property "displayFormat" - WITH SOLUTION

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.6
• Fix Version/s: 2.0.7
• Component/s: Plugin - Tags

Environment

Windows XP machine, Pentium Mobile...

• Assignee: Musachy Barroso
• Reporter: Alexander Picoli
• Created: 27/Feb/07 20:00
• Updated: 28/Oct/12 22:11
• Resolved: 01/Mar/07 01:44

Description

>>>>> Here's "the bomb": <<<<<

I have a JSP snippet that looks like this:

<s:datetimepicker name="dataIni.date" value="%

{dataIni.dateRFC}

" displayFormat="%

{getText('dateFormat')}

"/>

>>>>> Here's "the BOOOM!" <<<<<

This "snippet" doesn't get rendered at all. Instead, at the application log, I get this:

ERROR:15:05:54,287; class: org.apache.catalina.core.StandardWrapperValve; method:invoke -(lin. 253):Servlet.service() for servlet default threw exception
java.lang.IllegalArgumentException: Illegal pattern character 'g'
at java.text.SimpleDateFormat.compile(SimpleDateFormat.java:678)
at java.text.SimpleDateFormat.initialize(SimpleDateFormat.java:497)
at java.text.SimpleDateFormat.<init>(SimpleDateFormat.java:446)
at java.text.SimpleDateFormat.<init>(SimpleDateFormat.java:427)
at org.apache.struts2.components.DateTimePicker.format(DateTimePicker.java:305)
...

>>>>> Here's the diagnosis: <<<<<

In the org.apache.struts2.components.DateTimePicker

component, the

private String format(Object obj) {

method has the following code snippet:

Date date = null;
if(this.displayFormat != null) {
SimpleDateFormat format = new SimpleDateFormat(
this.displayFormat);
date = format.parse(dateStr);

The problem with this code is that "this.displayFormat" is the "Source Expression", before ognl evaluation, and not the result parameter.

>>>>> The SOLUTION <<<<<
replace the format instanciation with this code snippet, that instead of using the unevaluated value of displayFormat, uses the
EVALUATED value;

Object disF = this.getParameters().get("displayFormat");
if(disF == null)

{ throw (new ParseException("Something is REALLY WRONG!!!! the displayFormat is being used BEFORE EVALUATION!!!",0)); }

SimpleDateFormat format = new SimpleDateFormat(
disF.toString());