Struts 2
  1. Struts 2
  2. WW-1704

Add the ParameterFilterInterceptor and ParameterRemoverInterceptor to struts-default.xml

    Details

    • Type: Task Task
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 2.0.5
    • Fix Version/s: 3.0
    • Component/s: XML Configuration
    • Labels:
      None
    • Flags:
      Important

      Description

      The ParameterFilterInterceptor is currently available in XW2, and very important to control (deep) setting of objects. Appearantly, we forgot to include it in the struts-default.xml file.

      Same goes for the new ParameterRemover interceptor. This one is currently available in XW1, but will be ported to XW2:

      See: http://jira.opensymphony.com/browse/XW-477

        Activity

        Hide
        Ian Roughley added a comment -

        let's use "param-name-filter" and "param-value-filter" for the interceptor configuration names.

        Show
        Ian Roughley added a comment - let's use "param-name-filter" and "param-value-filter" for the interceptor configuration names.
        Hide
        Ian Roughley added a comment -

        just noticed that the remove filter also checks name, so perhaps "param-namevalue-filter" is better

        Show
        Ian Roughley added a comment - just noticed that the remove filter also checks name, so perhaps "param-namevalue-filter" is better
        Hide
        Don Brown added a comment -

        I think the ParametersInterceptor was recently given the capability of filtering out parameters from the request. Let's make sure we don't duplicate the functionality.

        Show
        Don Brown added a comment - I think the ParametersInterceptor was recently given the capability of filtering out parameters from the request. Let's make sure we don't duplicate the functionality.
        Hide
        Philip Luppens added a comment -

        Yes, there's an excludeParams property on the interceptor that can be used in the ParametersInterceptor. However, the functionality of the ParameterRemoverInterceptor (remove a parameter based on name and matching value) is still unique. Should this also be implemented in one big interceptor ? I tend to agree with Tom here that it might be better to provide several specific, easy to override/extend, interceptors.

        Show
        Philip Luppens added a comment - Yes, there's an excludeParams property on the interceptor that can be used in the ParametersInterceptor. However, the functionality of the ParameterRemoverInterceptor (remove a parameter based on name and matching value) is still unique. Should this also be implemented in one big interceptor ? I tend to agree with Tom here that it might be better to provide several specific, easy to override/extend, interceptors.
        Hide
        Ian Roughley added a comment -

        If we go the route of everything in one big interceptor, we also need to ensure all the functionality is available from ParameterFilterInterceptor (allowed, blocked including sub-objects).

        Show
        Ian Roughley added a comment - If we go the route of everything in one big interceptor, we also need to ensure all the functionality is available from ParameterFilterInterceptor (allowed, blocked including sub-objects).
        Hide
        Ted Husted added a comment -

        Bumping to 2.1.0 for further discussion.

        Show
        Ted Husted added a comment - Bumping to 2.1.0 for further discussion.

          People

          • Assignee:
            Philip Luppens
            Reporter:
            Philip Luppens
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:

              Development